Skip to content

minor better nav heighting #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion preview-src/admonitions.adoc
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
= Admonitions
:check-mark: icon:check[]
// :page-disablefeedback: true


== NOTE
Expand Down Expand Up @@ -27,7 +28,7 @@ Eos suscipit scaevola at.

Cum dicat putant ne.
Est in reque homero principes, meis deleniti mediocrem ad has.
Altera atomorum his ex, has cu elitr melius propriae.
// Altera atomorum his ex, has cu elitr melius propriae.

[TIP]
====
Expand Down
30 changes: 15 additions & 15 deletions preview-src/ui-model.yml
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,21 @@ page:
- content: GraphGists
url: graph-gist-index.html
urlType: internal
- content: Star Wars Social Network
url: graph-gist-star-wars-social-network.html
urlType: internal
- content: First Steps with Cypher
url: first-steps-with-cypher.html
urlType: internal
- content: Category Pop Culture
url: graph-gist-category-pop-culture.html
urlType: internal
- content: Contribute
url: contribute.html
urlType: internal
- content: Promos
url: promos.html
urlType: internal
- content: Reference - a long title that also has child pages
items:
- content: Keyboard Shortcuts
Expand All @@ -283,21 +298,6 @@ page:
- content: English + 中文
url: '/xyz/4.1/index.html#english+中文'
urlType: internal
- content: Star Wars Social Network
url: graph-gist-star-wars-social-network.html
urlType: internal
- content: First Steps with Cypher
url: first-steps-with-cypher.html
urlType: internal
- content: Category Pop Culture
url: graph-gist-category-pop-culture.html
urlType: internal
- content: Contribute
url: contribute.html
urlType: internal
- content: Promos
url: promos.html
urlType: internal
# additional page attributes indexed by page-slug
pages-data:
cheatsheet-products: &cheatsheet-products
Expand Down
5 changes: 3 additions & 2 deletions src/css/nav.css
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,9 @@ html.is-clipped--nav {
position: relative;
}

.nav-panel-manu.has-feedback .nav-menu {
margin-bottom: calc(var(--feedback-height) + 1rem);
.nav-panel-menu.has-feedback {
height: calc(var(--nav-panel-height--desktop) - var(--feedback-height) - 1.5rem);
padding-bottom: calc(var(--feedback-height) * 1.5);
}

.nav-menu .component-title {
Expand Down
6 changes: 1 addition & 5 deletions src/css/vars.css
Original file line number Diff line number Diff line change
Expand Up @@ -406,11 +406,7 @@
--nav-height: calc(var(--body-min-height) - var(--toolbar-height));
--nav-height--desktop: var(--body-min-height);
--nav-panel-height: calc(var(--nav-height) - var(--drawer-height));
--nav-panel-height--desktop:
calc(
var(--nav-height--desktop) - var(--drawer-height) - var(--feedback-height) * 8px
); /* 1rem is feedback padding */

--nav-panel-height--desktop: calc(var(--nav-height--desktop) - var(--drawer-height));
--nav-width: 18rem;
--toc-top: calc(var(--body-top) + var(--toolbar-height));
--kb-metadata-top: calc(var(--body-top) + var(--toolbar-height));
Expand Down
2 changes: 1 addition & 1 deletion src/partials/nav-menu.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
</div>
</aside>
{{else}}
<div class="nav-panel-menu is-active" data-panel="menu">
<div class="nav-panel-menu is-active{{#unless page.attributes.disablefeedback}} has-feedback{{/unless}}" data-panel="menu">
<nav class="nav-menu">
{{#with page.navigation}}{{> nav-tree navigation=this module=@root.page.module}}{{/with}}
</nav>
Expand Down