Skip to content

NEP-51: Token Standard Requiring Optional Methods #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

NEP-51: Token Standard Requiring Optional Methods #58

wants to merge 8 commits into from

Conversation

M-L-A
Copy link

@M-L-A M-L-A commented Jul 21, 2018

See issue: #59

@M-L-A M-L-A changed the title Create nep-51.mediawiki NEP 51: Token Standard Requiring Optional Methods Jul 21, 2018
@M-L-A M-L-A changed the title NEP 51: Token Standard Requiring Optional Methods NEP-51: Token Standard Requiring Optional Methods Jul 21, 2018
nep-51.mediawiki Outdated
* Syntax: <code>public static event Action<byte[], byte[], BigInteger> transfer</code>

* Remarks: The "transfer" event is raised after a successful execution of the "transfer" method.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want an approve event?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For previous discussion on optional events, we can refer to the discussion on the original NEP-5 here: #4

In defense of approve, it allows people to transfer on behalf on someone, which people may find useful.

@RavenXce
Copy link

This lacks the necessary details for the new (and also existing) methods, so we can't discuss anything. Better to base of the current NEP-5 doc https://github.com/neo-project/proposals/blob/master/nep-5.mediawiki.

To be more in line with current version
@M-L-A
Copy link
Author

M-L-A commented Jul 21, 2018

Have updated to be more in line with current version. Details should be enough to begin discussion. As mentioned, this is the "original" NEP-5 that has been in place (Finalized) since last year, until recently redacted to remove optional methods. Because many projects are currently using these methods (referred to NEP 5.1), and NEP-5 no longer contains those methods for people to find, this NEP becomes necessary.

@canesin
Copy link

canesin commented Jul 21, 2018

@RavenXce we have been recommending this implementation due to a needed change in the VM. Please contact me or @localhuman in discord or email, as you feel best, so we clarify the needed changes in the way you call some contracts.

We all understand that a new token standard that just reinstitute a old one is not ideal, but unfortunately a oversight let a new standard proposal at the same time change the at time already finalized NEP5, now we have issues communicating across social channels that can put projects at risk.

@anfn101 this proposal should mark NEP5 status as "replaced" so people don't fall in that mistake.

@M-L-A
Copy link
Author

M-L-A commented Jul 21, 2018

I have added a note to NEP-5 saying something to the tone of that.

@mwherman2000
Copy link
Contributor

mwherman2000 commented Jul 21, 2018

@totalvamp @afong @tyler @lllwvlvwlll @erikzhang #58 is non compliant with the current direction that has previously been established for NEPs. It should only contain the incremental merthods. Nothing more. That is was agreed to. #GangOfZion being destructive again.

@erikzhang, to you as the NEP Editor, I recommend against you accepting this NEP.

An NEP-10 compliant solution to this issue can be found in this PR: #60

Copy link
Contributor

@mwherman2000 mwherman2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RavenXce This continued patterns of destructive community behavior led by @canesin and his Gang of Zion are going to destroy the NEO community.

nep-51.mediawiki Outdated
* Syntax: <code>public static event Action<byte[], byte[], BigInteger> transfer</code>

* Remarks: The "transfer" event is raised after a successful execution of the "transfer" method.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@totalvamp @afong @tyler @lllwvlvwlll @erikzhang #58 is non compliant with the current direction that has previously been established for NEPs. It should only contain the incremental merthods. Nothing more. That is was agreed to. #GangOfZion being destructive again.

@erikzhang, to you as the NEP Editor, I recommend against you accepting this NEP.

@EdgeDLT
Copy link

EdgeDLT commented Jul 21, 2018

@erikzhang @mwherman2000

Michael's opposition to #58 is based on a supposed community consensus for a new NEP direction & demand against retroactive changes.

However, this current direction had no community consensus; instead, Michael has justified it based on his own preferences that went largely undiscussed for 30 days.

In addition, the only retroactive changes that have been made so far are Michael's own handiwork, where he retroactively changed a finalized NEP and subsequently re-proposed it under his own name.

I suggest this objection is ignored entirely, and NEP-51 is finalized to supersede NEP-5.

@mwherman2000
Copy link
Contributor

@edgegasm You can read through the community based discussion, acceptance, and finalization of NEP-10 here: #40

@EdgeDLT
Copy link

EdgeDLT commented Jul 21, 2018

@mwherman2000

On 12th May, you pointed out your concept of removing optional methods from NEPs going forward (an agreeable suggestion).

On 14th May, Erik agreed that there should not be optional methods; just new NEPs for separate methods.

On 17th May, you retroactively removed the existing methods from a finalized NEP (an unacceptable act that has caused much confusion to this date).

In what dimension is a conversation solely between you and Erik over the span of five days a 'community based discussion?' Do you see how ludicrous that is from the perspective of someone that has been noting your own belligerence towards members of CoZ, for supposedly basing decisions on private discussions rather than community involvement? I find it to be wholly unacceptable and hypocritical.

@canesin
Copy link

canesin commented Jul 21, 2018

Just to publicly update I talked with @RavenXce in private to clarify. The intention was not to be disrespectful to any member of the broader community but unfortunately not every issue can be discussed in the open as it could damage projects.

Thank you for the comprehension, several members of the community have expressed the need for a forum, in which we are now working to establish, to channel this sometimes more heated (but usually well intention ed) discussions, as more traditional watchers and people not so familiar with open source chaos (to those interested I invite the read of the now classic "The Cathedral and the Bazaar" text: http://www.unterstein.net/su/docs/CathBaz.pdf).

@saltyskip
Copy link
Contributor

#61 or #60 seem to be a better solution as it does not break compatibility of existing projects, and allows us to maintain NEP-5 as the base token standard, with or without extensions

@erikzhang
Copy link
Member

#61 or #60 seem to be a better solution as it does not break compatibility of existing projects, and allows us to maintain NEP-5 as the base token standard, with or without extensions

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants