Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP: Passphrase-protected private key #2

Merged
merged 7 commits into from
Oct 9, 2017
Merged

NEP: Passphrase-protected private key #2

merged 7 commits into from
Oct 9, 2017

Conversation

erikzhang
Copy link
Member

A method is proposed for encrypting and encoding a passphrase-protected private key record in the form of a 58-character Base58Check-encoded printable string. Encrypted private key records are intended for use on paper wallets. Each record string contains all the information needed to reconstitute the private key except for a passphrase, and the methodology uses salting and scrypt to resist brute-force attacks.

Copy link

@Ejhfast Ejhfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, will be a good next step for improving security in Neon wallet. Love the idea of a common standard for this as well

@canesin
Copy link

canesin commented Aug 6, 2017

With all the talk about quantum resistance shouldn't we take advantage of the clean slate and setup a standard using something like RLWE to encrypt the keys instead of AES ?

@erikzhang
Copy link
Member Author

This method can resist the quantum computer.
Because in the final step of decryption, the decrypter needs to compute the NEO address to verify that the decryption result is correct. In this process, hashing algorithms are not easily implemented by quantum computers.

@canesin
Copy link

canesin commented Aug 17, 2017

@erikzhang You didn't merge the PR but the branch ... Could you close this PR them ? (considering the NEP-2 design is final)

@erikzhang
Copy link
Member Author

Each pull request for NEP will be merged when it is in a final status. The current status of it is accepted.
You can check the work flow here.

@erikzhang erikzhang merged commit 17c9b2d into master Oct 9, 2017
@erikzhang erikzhang deleted the nep-2 branch October 9, 2017 06:41
@mwherman2000 mwherman2000 mentioned this pull request Jun 22, 2018
erikzhang pushed a commit that referenced this pull request Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants