Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with LegalizeLayoutTranform which added duplicate ops #81

Merged

Conversation

trevor-m
Copy link

LegalizeLayoutTransform visitor was not replacing layout_transform with transpose properly.

@trevor-m
Copy link
Author

@anijain2305

@@ -186,6 +185,7 @@ def EnableTrt(mod, params=None, trt_version=None):
mod = relay.transform.RemoveUnusedFunctions()(mod)
mod = relay.transform.InferType()(mod)
mod = relay.transform.ConvertLayout('NCHW')(mod)
print(mod['main'])

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the print?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, fixed.

@trevor-m trevor-m force-pushed the trevmorr-fix-trt-legalize-layout-transform branch from 9bfc36d to 994a73f Compare January 30, 2020 22:42
Copy link

@anijain2305 anijain2305 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trevor-m trevor-m merged commit 3188a68 into neo-ai:dev Jan 30, 2020
trevor-m added a commit to trevor-m/tvm that referenced this pull request Feb 28, 2020
trevor-m added a commit to trevor-m/tvm that referenced this pull request Mar 16, 2020
trevor-m added a commit to trevor-m/tvm that referenced this pull request Mar 25, 2020
trevor-m added a commit to trevor-m/tvm that referenced this pull request Apr 10, 2020
trevor-m added a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
trevor-m added a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants