Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Remove NNVM/TRT compiler tests. #76

Merged
merged 1 commit into from
Jan 10, 2020
Merged

[Cleanup] Remove NNVM/TRT compiler tests. #76

merged 1 commit into from
Jan 10, 2020

Conversation

trevor-m
Copy link

@trevor-m trevor-m commented Jan 10, 2020 •
edited
Loading

Recent upstream sync removed NNVM. This PR removes tests related to NNVM/TRT integration compile side which is now gone.

Note that NNVM/TRT runtime is still present and unaffected by this PR.

yongwww
yongwww approved these changes Jan 10, 2020
View reviewed changes
Copy link

@yongwww yongwww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiics
zhiics approved these changes Jan 10, 2020
View reviewed changes
Copy link

@zhiics zhiics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this pr, we may want to have a followup to remove the runtime change as well.

@zhiics zhiics merged commit 792a8a5 into neo-ai:dev Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiics zhiics zhiics approved these changes

@yongwww yongwww yongwww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trevor-m @zhiics @yongwww