Use int for endch to fix portability issues regarding signed/unsigned…

… char (#75)
neo-ai · Jan 24, 2020 · 98b8ca4 · 98b8ca4
1 parent ea78f1d
commit 98b8ca4
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/common/base64.h b/src/common/base64.h
@@ -258,7 +258,7 @@ class Base64OutStream: public dmlc::Stream {
    * \brief finish writing of all current base64 stream, do some post processing
    * \param endch character to put to end of stream, if it is EOF, then nothing will be appended.
    */
-  void Finish(char endch = EOF) {
+  void Finish(int endch = EOF) {
     using base64::EncodeTable;
     if (buf__top_ == 1) {
       PutChar(EncodeTable[buf_[1] >> 2]);