-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitter fails for sliced connections and probes #205
Labels
Comments
arvoelke
changed the title
Splitter tries to put node on chip for sliced connection
Splitter fails for sliced connections and probes
Mar 27, 2019
Here's a simpler test that fails with the same error message: with nengo.Network() as model:
a = nengo.Ensemble(1, 1, label="a")
p = nengo.Probe(a[0])
with nengo_loihi.Simulator(model) as sim:
pass |
Merged
hunse
pushed a commit
that referenced
this issue
Apr 3, 2019
Most of the work done by the splitter is now done in the builder. This should give more clarity and control over the mapping between pre-build and post-build objects. The `SplitterDirective` class takes on the organizational tasks of the old `Splitter`, giving directives to the builder about what should be on- or off-chip. Also: - Add unit tests for splitter refactoring. - Raise `BuildError` if learning objects are on_chip. Fixes #208 and #209. - Pass no decoder cache to sub-models. Decoder cache wasn't working due to lack of context manager which is normally constructed by the top-level network build. Fixes #207. - Various improvements to passthrough removal, including not removing useful passthrough nodes. Outstanding issues include: #210, #212, #213 - Handle sliced probes. Closes #205. - Check that splitter handles sliced probes. Closes #206. - Test that splitter does not mutate network. Closes #211.
hunse
pushed a commit
that referenced
this issue
Apr 3, 2019
Most of the work done by the splitter is now done in the builder. This should give more clarity and control over the mapping between pre-build and post-build objects. The `SplitterDirective` class takes on the organizational tasks of the old `Splitter`, giving directives to the builder about what should be on- or off-chip. Also: - Add unit tests for splitter refactoring. - Raise `BuildError` if learning objects are on_chip. Fixes #208 and #209. - Pass no decoder cache to sub-models. Decoder cache wasn't working due to lack of context manager which is normally constructed by the top-level network build. Fixes #207. - Various improvements to passthrough removal, including not removing useful passthrough nodes. Outstanding issues include: #210, #212, #213 - Handle sliced probes. Closes #205. - Check that splitter handles sliced probes. Closes #206. - Test that splitter does not mutate network. Closes #211.
hunse
pushed a commit
that referenced
this issue
Apr 9, 2019
Most of the work done by the splitter is now done in the builder. This should give more clarity and control over the mapping between pre-build and post-build objects. The `SplitterDirective` class takes on the organizational tasks of the old `Splitter`, giving directives to the builder about what should be on- or off-chip. Also: - Add unit tests for splitter refactoring. - Raise `BuildError` if learning objects are on_chip or learning and `precompute` are combined. Fixes #208 and #209. - Pass no decoder cache to sub-models. Decoder cache wasn't working due to lack of context manager which is normally constructed by the top-level network build. Fixes #207. - Handle sliced probes. Closes #205. - Check that splitter handles sliced probes. Closes #206. - Test that splitter does not mutate network. Closes #211. - Simulation is now identical whether precompute is True or False, on both emulator and chip. The tolerance for test_precompute is now zero.
tbekolay
pushed a commit
that referenced
this issue
Apr 15, 2019
Most of the work done by the splitter is now done in the builder. This should give more clarity and control over the mapping between pre-build and post-build objects. The `SplitterDirective` class takes on the organizational tasks of the old `Splitter`, giving directives to the builder about what should be on- or off-chip. Also: - Add unit tests for splitter refactoring. - Raise `BuildError` if learning objects are on_chip or learning and `precompute` are combined. Fixes #208 and #209. - Pass no decoder cache to sub-models. Decoder cache wasn't working due to lack of context manager which is normally constructed by the top-level network build. Fixes #207. - Handle sliced probes. Closes #205. - Check that splitter handles sliced probes. Closes #206. - Test that splitter does not mutate network. Closes #211. - Simulation is now identical whether precompute is True or False, on both emulator and chip. The tolerance for test_precompute is now zero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following code has different behaviour for connections from
a[0]
versusa
even though they are the same object (a
is one-dimensional).The text was updated successfully, but these errors were encountered: