Remote docs #60
Remote docs #60
Conversation
| rm -rf {{ docs_dir }} | ||
| cd .. | ||
| rm -rf nengo-fpga-"$TRAVIS_JOB_NUMBER" | ||
| conda env remove -y -n travis-ci-"$TRAVIS_JOB_NUMBER" |
There was a problem hiding this comment.
I don't see this in the new generated script... Is this handled differently now?
There was a problem hiding this comment.
No I think we should have this in there, I just neglected to add this in since I was relying on the templated scripts, but those are for VMs so we definitely want to put this back in 👍
Do we want to omit the miniconda install pieces too? I think it would be cleaner to leave that in so we don't need to modify the base tempalte as much... not sure if there are any adverse effects of it grabbing the installer and trying to install again?
There was a problem hiding this comment.
If we leave the miniconda install part in there, where does it install it to? Does it keep installing additional copies of miniconda every time the script runs?
Also, I'm not convinced putting in the conda cleanup should be in our scripts. I think it might be more an nengo-bones issue... It should do proper cleanup, VM or not.
There was a problem hiding this comment.
As an example, the stuff being run on the azure cloud is a VM, but a persistent VM (i think), so you would still want the conda cleanup there.
There was a problem hiding this comment.
|
Couple notes I want to write down:
|
- Removed old docs template and ssh info
Motivation and context:
Switch to a remote script which actively tracks changes instead of custom, manually written script.
Interactions with other PRs:
This supersedes #56, we can close, and ignore that PR in favour of this one
How long should this take to review?
Types of changes:
Checklist: