Reworked socket code for FpgaPesEnsembleNetwork #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorcos
reviewed
Mar 10, 2020
bmorcos
approved these changes
Mar 10, 2020
- Simplified socket code for FpgaPesEnsembleNetwork. Now uses basic python sockets instead of the sockets class. - Moved the socket connection logic to the `connect` function instead of it being in the socket_node function. This corrects the Nengo simulation time progress bar as the udp connection now happens before the simulation starts. - Modified socket node to use SimPyFunc instead of Nengo processes (SimPyFunc is faster). - Removed `seed` parameter from SSH command. - Added a 0.1s delay between the SSH client invocation and sending the SSH command string to the board. This is to allow the client to be properly loaded before the string is sent. Multiple back-to-back runs were occasionally throwing errors (could not connect to SSH client) without this delay. - Removed sockets.py file. No longer in use. - Made separate function for extracting and saving the network parameters to files. This is to simplify the build_FpgaPesEnsembleNetwork function. - Moved udp_comm_func out of build function context and used functools.partial to call it from SimPyFunc. - Make changelog formatting consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
Rewrote socket code to improve communication speed between host PC and board. Also addressed error handling issues between the board and PC (either side can now be terminated by the other side now).
How has this been tested?
Tested with the various examples in the examples folder. Also tested by modifying the board side script to terminate prematurely, and by prematurely terminating the PC simulation and checking if the board side script terminates as well.
How long should this take to review?
Where should a reviewer start?
Start with reviewing the FPGAPesNetwork file.
Types of changes:
Checklist:
Still to do: