Added spiking to feedback notebooks #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorcos
suggested changes
Dec 18, 2019
bmorcos
suggested changes
Dec 19, 2019
- Added spiking network versions to the integrator, simple oscillator, controlled oscillator, and chaotic attractor notebooks. - Modified controlled oscillator plot so that it would compute appropriate axis ticks even if the outputs were < 1. Previously, in this situation, there would only be one axis tick at 0. - Modified controlled oscillator speed plot so that the axis limits were dependent on the speed output, not the oscillator output. - Fixed pylint and flake8 errors with the notebooks. - Added blurb about difference in outputs between spiking and non-spiking networks.
bmorcos
force-pushed
the
feedback_spiking_notebooks
branch
from
1b72319
to
d30d415
Compare
bmorcos
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context:
The feedback notebooks did not demonstrate it working with spiking neurons. This PR addresses this concern.
How has this been tested?
Notebooks have been built on my local system. Everything seems to be as expected. Static CI script has also been run on the code to address flake8/pylint issues.
How long should this take to review?
Where should a reviewer start?
Start by building the docs and looking at the integrator notebook.
Types of changes:
Checklist: