Repository navigation
fix: recognize function definition lines as scope openers - #30
Merged
Merged
Conversation
A Lua definition line like local function test() ends in a closing paren, so the opener heuristic never matched it. Pasting with ]p below a definition landed at the definition indent instead of the body level. Two new patterns catch definition statements and anonymous function heads at the end of a line, for example vim.schedule(function(). The word boundaries reject identifier characters, so call statements like function_helper(x) or my_function(data) stay non-openers. The clipboard spec expectation moves to the body level because its fixture pastes below a function definition. Refs #28
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The opener heuristic only matched line-ending tokens, and a definition line like local function test() ends in a closing paren, so pasting below it landed at the definition indent instead of the body level. Two new patterns catch definition statements and line-ending anonymous function heads, while call statements like function_helper(x) stay non-openers.
Closes #28