Repository navigation
fix: preserve registers in visual paste fallback - #26
Merged
Merged
Conversation
Native visual p yanks the replaced selection into the unnamed register, so pasting over text and then pasting again inserted the replaced text instead of the original yank. The smart linewise path already avoided this, but the charwise and blockwise fallbacks fed the pressed key through to native paste and clobbered the register. Feed the fallback as P instead. In visual mode p and P place text identically, the only difference is that P leaves registers untouched. Every visual paste now keeps register contents. Refs #25
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native visual p writes the replaced selection into the unnamed register. The smart linewise path already avoided this, but the charwise and blockwise fallbacks fed the pressed key through to native paste. The fallback now pastes with P, which places text the same way and leaves registers untouched.
Closes #25