return early instead of erroring out on nonstandard page

nelsonjchen · Nov 17, 2020 · 7848e3c · 7848e3c
1 parent 9143e5d
commit 7848e3c
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 22 deletions.
diff --git a/javascripts/events.js b/javascripts/events.js
@@ -192,6 +192,8 @@ export default function initializeEvents () {
     })
   })
 
+  if (!document.querySelector('.sidebar-products')) return
+
   // Navigate event
   Array.from(
     document.querySelectorAll('.sidebar-products details')

diff --git a/javascripts/index.js b/javascripts/index.js
@@ -19,26 +19,23 @@ import filterCodeExamples from './filter-code-examples'
 import allArticles from './all-articles'
 import devToc from './dev-toc'
 
-if (location.pathname.endsWith('/dev-toc')) {
+document.addEventListener('DOMContentLoaded', async () => {
+  displayPlatformSpecificContent()
+  explorer()
+  search()
+  nav()
+  browserDateFormatter()
+  deprecationBanner()
+  sidebar()
+  wrapCodeTerms()
+  print()
+  localization()
+  await fillCsrf() // this must complete before any POST calls
+  helpfulness()
+  experiment()
+  copyCode()
+  initializeEvents()
+  filterCodeExamples()
+  allArticles()
   devToc()
-} else {
-  document.addEventListener('DOMContentLoaded', async () => {
-    displayPlatformSpecificContent()
-    explorer()
-    search()
-    nav()
-    browserDateFormatter()
-    deprecationBanner()
-    sidebar()
-    wrapCodeTerms()
-    print()
-    localization()
-    await fillCsrf() // this must complete before any POST calls
-    helpfulness()
-    experiment()
-    copyCode()
-    initializeEvents()
-    filterCodeExamples()
-    allArticles()
-  })
-}
+})
diff --git a/javascripts/nav.js b/javascripts/nav.js
@@ -3,6 +3,8 @@ export default function () {
   const hamburgerButton = document.querySelector('.nav-mobile-burgerIcon')
   const mobileDropdown = document.querySelector('.nav-mobile-dropdown')
 
+  if (!(hamburgerButton && mobileDropdown)) return
+
   hamburgerButton.addEventListener('click', (event) => {
     event.preventDefault()
     hamburgerButton.classList.toggle('js-open')

diff --git a/javascripts/search.js b/javascripts/search.js
@@ -63,6 +63,8 @@ const resultTemplate = (item) => {
 }
 
 export default function () {
+  if (!document.querySelector('#search-results-container')) return
+
   window.initialPageLoad = true
   const opts = {