Streamline Deps exception path

For debugging, it's better to not rethrow an exception if possible. This code should be equivalent.
nelsonic · Apr 4, 2014 · 61a1bb5 · 61a1bb5
1 parent c65038c
commit 61a1bb5
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/packages/deps/deps.js b/packages/deps/deps.js
@@ -290,6 +290,7 @@ _assign(Deps, {
     willFlush = true;
     throwFirstError = !! (_opts && _opts._throwFirstError);
 
+    var finishedTry = false;
     try {
       while (pendingComputations.length ||
              afterFlushCallbacks.length) {
@@ -311,11 +312,13 @@ _assign(Deps, {
           }
         }
       }
-    } catch (e) {
-      inFlush = false; // needed before calling `Deps.flush()` again
-      Deps.flush({_throwFirstError: false}); // finish flushing
-      throw e;
+      finishedTry = true;
     } finally {
+      if (! finishedTry) {
+        // we're erroring
+        inFlush = false; // needed before calling `Deps.flush()` again
+        Deps.flush({_throwFirstError: false}); // finish flushing
+      }
       willFlush = false;
       inFlush = false;
     }