Enhance Install Script with Version Check and Force Install Option #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cplee
approved these changes
Dec 24, 2024
|
@james-crowley this pull request has failed checks 🛠 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2575 +/- ##
==========================================
+ Coverage 61.56% 68.75% +7.19%
==========================================
Files 53 71 +18
Lines 9002 10918 +1916
==========================================
+ Hits 5542 7507 +1965
+ Misses 3020 2848 -172
- Partials 440 563 +123 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces improvements to the Act install script by adding logic to check if Act is already installed. If the installed version matches the requested tag, the script will skip the installation process. This enhancement is particularly useful in CI environments where Act might already be preinstalled, reducing redundant downloads and saving bandwidth.
Key Changes:
Version Check Logic: The script now checks if Act is already installed and whether its version matches the requested tag. If a match is found, the installation is skipped.
Force Install Flag
-f: A new CLI flag -f has been added to bypass the version check. This ensures flexibility when users explicitly want to reinstall or downgrade Act.Upgrade & Downgrade: The script only skips installation if the installed version matches the requested tag. It doesn’t prevent downgrades or upgrades to different versions, offering control to the end user.