Skip to content

Conversation

@ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Jul 16, 2023

Prepare for new process and thread safe action cache.

RE

See public proposal in: #1785 (comment), it is also in the private discussions.

Known Issues in tests, due to missing mocks

Further issues in tests, will appear due to missing calls to copydir etc.

Prepare for new process and thread safe action cache
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.03s
✅ REPOSITORY gitleaks yes no 3.12s
✅ REPOSITORY git_diff yes no 0.15s
✅ REPOSITORY grype yes no 9.39s
✅ REPOSITORY secretlint yes no 1.61s
✅ REPOSITORY trivy-sbom yes no 0.73s
✅ REPOSITORY trufflehog yes no 9.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@ChristopherHX ChristopherHX marked this pull request as ready for review July 16, 2023 20:51
@ChristopherHX ChristopherHX requested a review from a team as a code owner July 16, 2023 20:51
@mergify
Copy link
Contributor

mergify bot commented Jul 16, 2023

@ChristopherHX this pull request has failed checks 🛠

Awaiting moby/moby#45935 to be fixed

@mergify mergify bot added the needs-work Extra attention is needed label Jul 16, 2023
}

func (cr *containerReference) CopyTarStream(ctx context.Context, destPath string, tarStream io.Reader) error {
err := cr.cli.CopyToContainer(ctx, cr.id, destPath, tarStream, types.CopyToContainerOptions{})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess non root container need more code here, like the chown..

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1912 (fbefec2) into master (4989f44) will increase coverage by 1.09%.
Report is 217 commits behind head on master.
The diff coverage is 62.62%.

@@            Coverage Diff             @@
##           master    #1912      +/-   ##
==========================================
+ Coverage   61.22%   62.31%   +1.09%     
==========================================
  Files          46       51       +5     
  Lines        7141     8349    +1208     
==========================================
+ Hits         4372     5203     +831     
- Misses       2462     2744     +282     
- Partials      307      402      +95     
Files Changed Coverage Δ
pkg/common/outbound_ip.go 0.00% <0.00%> (ø)
pkg/container/docker_cli.go 82.23% <ø> (ø)
pkg/container/docker_logger.go 52.08% <ø> (ø)
pkg/container/docker_volume.go 0.00% <0.00%> (ø)
pkg/container/file_collector.go 39.68% <0.00%> (+2.38%) ⬆️
pkg/container/host_environment.go 0.00% <0.00%> (ø)
...ontainer/linux_container_environment_extensions.go 23.07% <0.00%> (-1.25%) ⬇️
pkg/container/util.go 0.00% <0.00%> (ø)
pkg/exprparser/functions.go 66.32% <0.00%> (-1.04%) ⬇️
pkg/container/docker_run.go 13.45% <7.14%> (-0.13%) ⬇️
... and 28 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot removed the needs-work Extra attention is needed label Jul 17, 2023
@mergify mergify bot merged commit 6468dd7 into master Aug 8, 2023
@mergify mergify bot deleted the copytarstream branch August 8, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants