-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: Add CopyTarStream to Container Interface #1912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Prepare for new process and thread safe action cache
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Awaiting moby/moby#45935 to be fixed |
| } | ||
|
|
||
| func (cr *containerReference) CopyTarStream(ctx context.Context, destPath string, tarStream io.Reader) error { | ||
| err := cr.cli.CopyToContainer(ctx, cr.id, destPath, tarStream, types.CopyToContainerOptions{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess non root container need more code here, like the chown..
Codecov Report
@@ Coverage Diff @@
## master #1912 +/- ##
==========================================
+ Coverage 61.22% 62.31% +1.09%
==========================================
Files 46 51 +5
Lines 7141 8349 +1208
==========================================
+ Hits 4372 5203 +831
- Misses 2462 2744 +282
- Partials 307 402 +95
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Prepare for new process and thread safe action cache.
RE
See public proposal in: #1785 (comment), it is also in the private discussions.
Known Issues in tests, due to missing mocks
Further issues in tests, will appear due to missing calls to copydir etc.