Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/rhysd/actionlint from 1.6.17 to 1.6.18 #1352

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 19, 2022

Bumps github.com/rhysd/actionlint from 1.6.17 to 1.6.18.

Release notes

Sourced from github.com/rhysd/actionlint's releases.

v1.6.18

  • This release much enhances checks for local reusable workflow calls. Note that these checks are done for local reusable workflows (starting with ./). (#179).
    • Detect missing required inputs/secrets and undefined inputs/secrets at jobs.<job_id>.with and jobs.<job_id>.secrets. See the document for more details.
      # .github/workflows/reusable.yml
      on:
        workflow_call:
          inputs:
            name:
              type: string
              required: true
          secrets:
            password:
              required: true
      ...
      .github/workflows/test.yml
      ...
      jobs:
      missing-required:
      uses: ./.github/workflows/reusable.yml
      with:
      # ERROR: Undefined input "user"
      user: rhysd
      # ERROR: Required input "name" is missing
      secrets:
      # ERROR: Undefined secret "credentials"
      credentials: my-token
      # ERROR: Required secret "password" is missing

    • Type check for reusable workflow inputs at jobs.<job_id>.with. Types are defined at on.workflow_call.inputs.<name>.type in reusable workflow. actionlint checks types of expressions in workflow calls. See the document for more details.
      # .github/workflows/reusable.yml
      on:
        workflow_call:
          inputs:
            id:
              type: number
            message:
              type: string
      ...
      .github/workflows/test.yml
      ...
      jobs:
      type-checks:
      uses: ./.github/workflows/reusable.yml
      with:

... (truncated)

Changelog

Sourced from github.com/rhysd/actionlint's changelog.

v1.6.18 - 17 Sep 2022

  • This release much enhances checks for local reusable workflow calls. Note that these checks are done for local reusable workflows (starting with ./). (#179).
    • Detect missing required inputs/secrets and undefined inputs/secrets at jobs.<job_id>.with and jobs.<job_id>.secrets. See the document for more details.
      # .github/workflows/reusable.yml
      on:
        workflow_call:
          inputs:
            name:
              type: string
              required: true
          secrets:
            password:
              required: true
      ...
      .github/workflows/test.yml
      ...
      jobs:
      missing-required:
      uses: ./.github/workflows/reusable.yml
      with:
      # ERROR: Undefined input "user"
      user: rhysd
      # ERROR: Required input "name" is missing
      secrets:
      # ERROR: Undefined secret "credentials"
      credentials: my-token
      # ERROR: Required secret "password" is missing

    • Type check for reusable workflow inputs at jobs.<job_id>.with. Types are defined at on.workflow_call.inputs.<name>.type in reusable workflow. actionlint checks types of expressions in workflow calls. See the document for more details.
      # .github/workflows/reusable.yml
      on:
        workflow_call:
          inputs:
            id:
              type: number
            message:
              type: string
      ...
      .github/workflows/test.yml
      ...
      jobs:
      type-checks:
      uses: ./.github/workflows/reusable.yml

... (truncated)

Commits
  • 14b8067 bump up version to v1.6.18
  • dc6c65b do not run go generate when linting files on CI
  • 851954c Merge pull request #215 from rhysd/ci/3071750523
  • c57c1ba update generated files by go generate on CI
  • 293a0eb describe errors on workflow call with undefined inputs
  • b32fb43 fix fuzz tests build error
  • 89879ab add missing runner.debug property and fix type of services.\<id>.ports
  • 7e1e2c7 describe error raised when local workflow does not exist
  • 3136b0a add missing github.action_status property
  • 05888fd Merge branch 'workflow-call-check' (fix #179)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/rhysd/actionlint](https://github.com/rhysd/actionlint) from 1.6.17 to 1.6.18.
- [Release notes](https://github.com/rhysd/actionlint/releases)
- [Changelog](https://github.com/rhysd/actionlint/blob/main/CHANGELOG.md)
- [Commits](rhysd/actionlint@v1.6.17...v1.6.18)

---
updated-dependencies:
- dependency-name: github.com/rhysd/actionlint
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner September 19, 2022 02:09
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Sep 19, 2022
@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #1352 (490b117) into master (4f8da0a) will increase coverage by 4.10%.
The diff coverage is 73.95%.

@@            Coverage Diff             @@
##           master    #1352      +/-   ##
==========================================
+ Coverage   57.50%   61.61%   +4.10%     
==========================================
  Files          32       40       +8     
  Lines        4594     5567     +973     
==========================================
+ Hits         2642     3430     +788     
- Misses       1729     1865     +136     
- Partials      223      272      +49     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 13.73% <13.73%> (+8.18%) ⬆️
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
pkg/container/file_collector.go 45.87% <45.87%> (ø)
pkg/common/git/git.go 50.00% <47.91%> (ø)
pkg/container/docker_auth.go 47.61% <50.00%> (+2.61%) ⬆️
pkg/model/workflow.go 54.32% <50.00%> (+3.40%) ⬆️
pkg/exprparser/interpreter.go 73.37% <53.48%> (-0.02%) ⬇️
pkg/model/planner.go 50.98% <57.14%> (+0.56%) ⬆️
... and 30 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mergify mergify bot merged commit 053bff1 into master Sep 19, 2022
@mergify mergify bot deleted the dependabot/go_modules/github.com/rhysd/actionlint-1.6.18 branch September 19, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants