Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure all post steps are executed #1286

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

KnisterPeter
Copy link
Member

This fixes an issue in the chain of post steps introduced
while updating the step-logger for composite actions.

It includes a test case so we make sure this does not happen
again.

This fixes an issue in the chain of post steps introduced
while updating the step-logger for composite actions.

It includes a test case so we make sure this does not happen
again.
@KnisterPeter KnisterPeter added the kind/bug Something isn't working label Jul 29, 2022
@KnisterPeter KnisterPeter self-assigned this Jul 29, 2022
@KnisterPeter KnisterPeter requested a review from a team as a code owner July 29, 2022 09:53
@github-actions
Copy link
Contributor

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 0.95s
✅ EDITORCONFIG editorconfig-checker 2 0 0.01s
✅ GIT git_diff yes no 0.0s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #1286 (b489380) into master (4f8da0a) will increase coverage by 4.16%.
The diff coverage is 74.46%.

@@            Coverage Diff             @@
##           master    #1286      +/-   ##
==========================================
+ Coverage   57.50%   61.67%   +4.16%     
==========================================
  Files          32       40       +8     
  Lines        4594     5529     +935     
==========================================
+ Hits         2642     3410     +768     
- Misses       1729     1848     +119     
- Partials      223      271      +48     
Impacted Files Coverage Δ
pkg/model/action.go 0.00% <0.00%> (ø)
pkg/model/step_result.go 0.00% <ø> (ø)
pkg/container/docker_run.go 14.03% <16.07%> (+8.49%) ⬆️
pkg/container/docker_pull.go 33.33% <33.33%> (ø)
pkg/container/file_collector.go 45.87% <45.87%> (ø)
pkg/common/git/git.go 50.00% <47.91%> (ø)
pkg/container/docker_auth.go 47.61% <50.00%> (+2.61%) ⬆️
pkg/model/workflow.go 54.32% <50.00%> (+3.40%) ⬆️
pkg/exprparser/interpreter.go 73.37% <53.48%> (-0.02%) ⬇️
pkg/model/planner.go 50.73% <60.00%> (+0.32%) ⬆️
... and 30 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mergify mergify bot merged commit 3364f95 into master Jul 29, 2022
@mergify mergify bot deleted the ensure-post-steps-are-running branch July 29, 2022 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants