-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: ignore already closed error #1285
Conversation
This hides the `file already cloesd` error as it is distracting in the output and does not provide any value.
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Codecov Report
@@ Coverage Diff @@
## master #1285 +/- ##
==========================================
+ Coverage 57.50% 61.62% +4.11%
==========================================
Files 32 40 +8
Lines 4594 5529 +935
==========================================
+ Hits 2642 3407 +765
- Misses 1729 1850 +121
- Partials 223 272 +49
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
@KnisterPeter this pull request has failed checks 🛠 |
You also removed the nil check for the error, this could cause a log print with a nil err. No I didn't test this change yet |
I've tested it and it's fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't trigger a nil error print, other than that it looks much cleaner than in the initial PR
We need to pin the linter version, it doesn't make sense to get a red check for existing code due to new linting rules
This hides the
file already cloesd
error as it isdistracting in the output and does not provide any value.