-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: keep action inputs #1215
fix: keep action inputs #1215
Conversation
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
Codecov Report
@@ Coverage Diff @@
## master #1215 +/- ##
==========================================
+ Coverage 57.50% 62.32% +4.81%
==========================================
Files 32 40 +8
Lines 4594 5401 +807
==========================================
+ Hits 2642 3366 +724
- Misses 1729 1772 +43
- Partials 223 263 +40
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
This could be closed when upstream nektos#1215 is merged
This could be closed when upstream nektos#1215 is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test, but this fix shouldn't wait for a test
This could be closed when upstream nektos#1215 is merged
@KnisterPeter this pull request is now in conflict 😩 |
Do not initialize inputs a second time (in pre and main step). When the action setup already run during pre step, we must not re-run it during the main step, otherwise the inputs will be overwritten by possible other action inputs.
ac0b242
to
7263a93
Compare
✅ Pull request refreshed |
1 similar comment
✅ Pull request refreshed |
Do not initialize inputs a second time (in pre and main step).
When the action setup already run during pre step, we must not
re-run it during the main step, otherwise the inputs will be
overwritten by possible other action inputs.
This is a regression introduced in #1204