result name clash #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm not sure why travis fails maybe because gcc 4.6 is to old |
Contributor
Author
|
the error "redisparser.cpp:364:47: error: ‘ParseParse’ was not declared in this scope" is strange. The work ParseParse does not appear once in the source file p.s. the test pass with current gcc and current clang |
Owner
ParseResult vs ParseParse. Please rename "resultParse" to "parseResult" |
burner
force-pushed
the
result_name_clash
branch
from
4575359 to
dc18d5e
Compare
Contributor
Author
|
fixed |
Owner
|
thank you |
1 similar comment
Contributor
Author
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
result is also a function