Swap 'sizeof' by 'strlen' in the request and response examples#2
Merged
nekipelov merged 1 commit intonekipelov:masterfrom Apr 29, 2020
Merged
Swap 'sizeof' by 'strlen' in the request and response examples#2nekipelov merged 1 commit intonekipelov:masterfrom
nekipelov merged 1 commit intonekipelov:masterfrom
Conversation
Fixes the request and response examples. As it stands, a '\0' character is being unnecessarily added to the parser, this caused messages cut in the middle of the headers to be treated as an error.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the request and response examples. As it stands, a '\0' character is being unnecessarily added to the parser, this caused messages cut in the middle of the headers to be treated as an error.
This probably solves this problem: #1