Skip to content

[Snyk] Upgrade react-scripts from 4.0.1 to 4.0.3 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 2 versions ahead of your current version.

  • The recommended version was released 4 years ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
high severity Prototype Pollution
SNYK-JS-IMMER-1019369
387 Proof of Concept
high severity Server-side Request Forgery (SSRF)
SNYK-JS-IP-6240864
387 Proof of Concept
high severity Improper Handling of Extra Parameters
SNYK-JS-FOLLOWREDIRECTS-6141137
387 Proof of Concept
high severity Asymmetric Resource Consumption (Amplification)
SNYK-JS-BODYPARSER-7926860
387 No Known Exploit
high severity Prototype Pollution
SNYK-JS-ASYNC-2441827
387 Proof of Concept
high severity Improper Input Validation
SNYK-JS-URLPARSE-2407770
387 Proof of Concept
high severity Remote Memory Exposure
SNYK-JS-DNSPACKET-1293563
387 No Known Exploit
medium severity Command Injection
SNYK-JS-REACTDEVUTILS-1083268
387 Proof of Concept
medium severity Information Exposure
SNYK-JS-EVENTSOURCE-2823375
387 Proof of Concept
medium severity Open Redirect
SNYK-JS-EXPRESS-6474509
387 No Known Exploit
medium severity Cross-site Scripting
SNYK-JS-EXPRESS-7926867
387 No Known Exploit
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2332181
387 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-7925106
387 Proof of Concept
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060
387 No Known Exploit
low severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2396346
387 No Known Exploit
critical severity Incomplete List of Disallowed Inputs
SNYK-JS-BABELTRAVERSE-5962462
387 Proof of Concept
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-6444610
387 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-8482416
387 Proof of Concept
medium severity Improper Input Validation
SNYK-JS-URLPARSE-1078283
387 No Known Exploit
medium severity Open Redirect
SNYK-JS-URLPARSE-1533425
387 Proof of Concept
medium severity Access Restriction Bypass
SNYK-JS-URLPARSE-2401205
387 Proof of Concept
medium severity Authorization Bypass
SNYK-JS-URLPARSE-2407759
387 Proof of Concept
medium severity Authorization Bypass Through User-Controlled Key
SNYK-JS-URLPARSE-2412697
387 Proof of Concept
low severity Cross-site Scripting
SNYK-JS-SEND-7926862
387 No Known Exploit
low severity Cross-site Scripting
SNYK-JS-SERVESTATIC-7926865
387 No Known Exploit
Release notes
Package name: react-scripts
  • 4.0.3 - 2021-02-22
  • 4.0.2 - 2021-02-03
  • 4.0.1 - 2020-11-23
from react-scripts GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3.

See this package in npm:
react-scripts

See this project in Snyk:
https://app.snyk.io/org/mohammadnewton/project/2a9da381-926c-417e-8136-77ebe2c34d98?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello team, gemini-code-assist here to provide a summary of this pull request. This PR, automatically generated by Snyk, aims to upgrade the react-scripts dependency from version 4.0.1 to 4.0.3. The primary motivation for this upgrade is to address a significant number of security vulnerabilities identified in the current version, including several high and critical severity issues. The changes are minimal, focusing solely on updating the dependency version in the package.json file.

Highlights

  • Dependency Upgrade: The core change in this PR is the upgrade of the react-scripts package from version 4.0.1 to 4.0.3. This is a minor version bump, moving two versions ahead of the current one.
  • Security Vulnerability Fixes: This upgrade is recommended by Snyk to fix a substantial list of security vulnerabilities. These include critical issues like Incomplete List of Disallowed Inputs, and high severity issues such as Prototype Pollution, Server-side Request Forgery (SSRF), and various others across several underlying dependencies of react-scripts.

Changelog

  • package.json
    • Updated the react-scripts dependency version from 4.0.1 to 4.0.3 (line 8).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Dependencies age,
Security flaws appear,
Upgrade keeps code safe.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This Snyk PR to upgrade react-scripts from 4.0.1 to 4.0.3 is a welcome change, addressing a significant number of security vulnerabilities as detailed in the PR description. Keeping dependencies up-to-date, especially those related to the build toolchain, is crucial for security and project stability.

Before merging, please ensure that:

  1. All automated tests (unit, integration, E2E) pass successfully with this updated version of react-scripts.
  2. If applicable, manual QA is performed on critical user flows to catch any unexpected regressions. While patch versions like this are generally expected to be backward compatible, thorough verification is always a good practice.

I've added one review comment with a medium severity regarding the longer-term maintenance strategy for react-scripts, which is intended for future planning rather than as a blocker for this beneficial update. Overall, this automated PR provides a valuable and straightforward security improvement.

Summary of Findings

  • Security Vulnerability Remediation: The upgrade of react-scripts from version 4.0.1 to 4.0.3 successfully addresses multiple documented security vulnerabilities, including several high-severity ones like Prototype Pollution and Server-side Request Forgery. This significantly enhances the project's security posture.
  • Long-term Dependency Management (react-scripts): While this patch to react-scripts@4.0.3 is beneficial, this version is from early 2021. It's recommended to plan a future migration to a more recent major version of react-scripts (e.g., 5.x) or an alternative modern build system. This will help in leveraging newer JavaScript features, performance optimizations, and ensure continued security updates and community support. This was noted as a medium-severity consideration for future planning in the review comments.

Merge Readiness

This pull request provides an important security update by upgrading react-scripts. Given the nature of the change (a patch update addressing known vulnerabilities) and the information that it's not a breaking change, I recommend merging it after successful completion of CI tests and any necessary manual QA.

The medium severity comment provided is for longer-term strategic planning regarding react-scripts and does not need to block the merging of this immediate security improvement.

As an AI, I am not authorized to approve pull requests. Please ensure this PR undergoes the standard review and approval process by the designated team members before merging.

@@ -5,7 +5,7 @@
"dependencies": {
"react": "^17.0.1",
"react-dom": "^17.0.1",
"react-scripts": "4.0.1"
"react-scripts": "4.0.3"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This upgrade to react-scripts@4.0.3 is a positive step for addressing the listed security vulnerabilities. Well done for automating this fix!

For future planning and long-term maintainability, it might be beneficial for the team to consider migrating to a newer major version of react-scripts (e.g., 5.x) or exploring more modern build tools. react-scripts 4.0.3 was released in February 2021, and newer versions or alternatives could offer performance improvements, new features, and more comprehensive long-term support.

Is this something that could be added to the technical roadmap for consideration? This suggestion is not intended to block the current PR, which is a clear improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants