-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade react-scripts from 4.0.1 to 4.0.3 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3. See this package in npm: react-scripts See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/d8f549f8-a2b9-4731-b64b-a65d1dfc20bb?utm_source=github&utm_medium=referral&page=upgrade-pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the project's security posture by performing a routine dependency upgrade, specifically targeting the react-scripts
package to address multiple known vulnerabilities.
Highlights
- Security Upgrade: The primary change involves upgrading the
react-scripts
dependency from version4.0.1
to4.0.3
. This upgrade is crucial as it resolves a total of 25 reported security vulnerabilities, including critical, high, medium, and low severity issues, as identified by Snyk. - Dependency Management: The
package.json
file has been updated to reflect the newreact-scripts
version, ensuring the project utilizes the more secure and up-to-date dependency.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This Snyk PR upgrades react-scripts
to 4.0.3
, fixing several security vulnerabilities. While this is a good interim fix, the target version is still very old and unmaintained. I've added a comment recommending a full upgrade to react-scripts
v5 and React 18 to ensure the long-term health and security of the project. This more significant upgrade should be prioritized as a follow-up.
@@ -5,7 +5,7 @@ | |||
"dependencies": { | |||
"react": "^17.0.1", | |||
"react-dom": "^17.0.1", | |||
"react-scripts": "4.0.1" | |||
"react-scripts": "4.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this upgrade to 4.0.3
is a good step to patch several security vulnerabilities, react-scripts
version 4 is quite old (released in early 2021) and is no longer actively maintained.
For better security and long-term project health, I strongly recommend upgrading to the latest major version of react-scripts
(5.0.1
). This will provide more recent versions of underlying tools like Webpack, Jest, and ESLint.
Important: Upgrading to react-scripts
v5 is a major change and will require you to also upgrade react
and react-dom
to v18 and adapt your application's entry point to use the new Root API.
If an immediate migration to v5 is not feasible, this PR is a reasonable interim step. However, a follow-up task to perform the major upgrade should be created and prioritized.
Snyk has created this PR to upgrade react-scripts from 4.0.1 to 4.0.3.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 2 versions ahead of your current version.
The recommended version was released 4 years ago.
Issues fixed by the recommended upgrade:
SNYK-JS-DNSPACKET-1293563
SNYK-JS-IMMER-1019369
SNYK-JS-IP-6240864
SNYK-JS-FOLLOWREDIRECTS-6141137
SNYK-JS-ASYNC-2441827
SNYK-JS-BODYPARSER-7926860
SNYK-JS-URLPARSE-2407770
SNYK-JS-PATHTOREGEXP-7925106
SNYK-JS-PATHTOREGEXP-8482416
SNYK-JS-EVENTSOURCE-2823375
SNYK-JS-EXPRESS-6474509
SNYK-JS-EXPRESS-7926867
SNYK-JS-FOLLOWREDIRECTS-2332181
SNYK-JS-FOLLOWREDIRECTS-6444610
SNYK-JS-REACTDEVUTILS-1083268
SNYK-JS-COOKIE-8163060
SNYK-JS-URLPARSE-1533425
SNYK-JS-URLPARSE-2401205
SNYK-JS-URLPARSE-2407759
SNYK-JS-FOLLOWREDIRECTS-2396346
SNYK-JS-BABELTRAVERSE-5962462
SNYK-JS-URLPARSE-1078283
SNYK-JS-URLPARSE-2412697
SNYK-JS-SEND-7926862
SNYK-JS-SERVESTATIC-7926865
Release notes
Package name: react-scripts
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: