-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0 #429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0. See this package in npm: @testing-library/jest-dom See this project in Snyk: https://app.snyk.io/org/mohammadnewton/project/22edd24b-54ca-4e0b-a30b-3a42f37de584?utm_source=github&utm_medium=referral&page=upgrade-pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, automatically generated by Snyk, focuses on enhancing the project's security by upgrading the @testing-library/jest-dom
dependency to its latest version, 5.17.0. This update is crucial for patching a wide array of identified security vulnerabilities present in the current dependency tree. Beyond security, the upgrade also brings a new testing matcher for improved accessibility testing.
Highlights
- Dependency Upgrade: The core change is the upgrade of the
@testing-library/jest-dom
package from version 5.16.5 to 5.17.0. - Security Vulnerability Fixes: This upgrade addresses a significant number of security vulnerabilities, including critical, high, and medium severity issues such as Code Injection, Prototype Pollution, Denial of Service (DoS), and Cross-site Scripting (XSS) found in various transitive dependencies.
- New Feature and Deprecation: The new version introduces a new feature,
toHaveAccessibleErrorMessage
, which better implements the accessibility specification, and deprecates the oldertoHaveErrorMessage
matcher.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request from Snyk upgrades @testing-library/jest-dom
to resolve numerous security vulnerabilities. The change is beneficial and recommended. I have one piece of feedback regarding dependency management to improve the project's structure.
@@ -3,7 +3,7 @@ | |||
"version": "0.1.0", | |||
"private": true, | |||
"dependencies": { | |||
"@testing-library/jest-dom": "^5.16.4", | |||
"@testing-library/jest-dom": "^5.17.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this version upgrade is correct, @testing-library/jest-dom
is a testing library and should be in devDependencies
, not dependencies
. Keeping testing-related packages in devDependencies
prevents them from being bundled into the production build, which helps reduce the final application size. The same principle applies to other @testing-library/*
packages currently in dependencies
.
Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 1 version ahead of your current version.
The recommended version was released 2 years ago.
Issues fixed by the recommended upgrade:
SNYK-JS-LODASHTEMPLATE-1088054
SNYK-JS-MERGE-1040469
SNYK-JS-MERGE-1042987
SNYK-JS-MICROMATCH-6838728
SNYK-JS-ELLIPTIC-8172694
SNYK-JS-FOLLOWREDIRECTS-6141137
SNYK-JS-LOADERUTILS-3105943
SNYK-JS-PROMPTS-1729737
SNYK-JS-REACTDEVUTILS-1083268
SNYK-JS-ELLIPTIC-7577918
SNYK-JS-ELLIPTIC-8187303
SNYK-JS-ELLIPTIC-8720086
SNYK-JS-HTTPPROXYMIDDLEWARE-8229906
SNYK-JS-IP-6240864
SNYK-JS-LOADERUTILS-3043105
SNYK-JS-UNSETVALUE-2400660
SNYK-JS-WEBPACKDEVMIDDLEWARE-6476555
SNYK-JS-WS-7266574
SNYK-JS-WS-7266574
SNYK-JS-EXPRESS-6474509
SNYK-JS-EXPRESS-7926867
SNYK-JS-FOLLOWREDIRECTS-6444610
SNYK-JS-FORMDATA-10841150
SNYK-JS-FORMDATA-10841150
SNYK-JS-ANSIHTML-1296849
SNYK-JS-GLOBPARENT-1016905
SNYK-JS-HTMLMINIFIER-3091181
SNYK-JS-IP-7148531
SNYK-JS-ISTANBULREPORTS-2328088
SNYK-JS-JSON5-3182856
SNYK-JS-LOADERUTILS-3042992
SNYK-JS-WEBPACK-7840298
SNYK-JS-YARGSPARSER-560381
SNYK-JS-YARGSPARSER-560381
SNYK-JS-WORDWRAP-3149973
SNYK-JS-BABELTRAVERSE-5962462
SNYK-JS-BABELTRAVERSE-5962463
SNYK-JS-SERIALIZEJAVASCRIPT-536840
SNYK-JS-SERIALIZEJAVASCRIPT-570062
SNYK-JS-SERIALIZEJAVASCRIPT-6056521
SNYK-JS-BODYPARSER-7926860
SNYK-JS-BRACES-6838727
SNYK-JS-BRACES-6838727
SNYK-JS-BRACES-6838727
SNYK-JS-BROWSERIFYSIGN-6037026
SNYK-JS-SHELLQUOTE-1766506
SNYK-JS-SSRI-1246392
SNYK-JS-CROSSSPAWN-8303230
SNYK-JS-MICROMATCH-6838728
SNYK-JS-MICROMATCH-6838728
SNYK-JS-NODEFORGE-2430339
SNYK-JS-REQUEST-3361831
SNYK-JS-BROWSERSLIST-1090194
SNYK-JS-SOCKJS-575261
SNYK-JS-TERSER-2806366
SNYK-JS-TOUGHCOOKIE-5672873
SNYK-JS-TOUGHCOOKIE-5672873
SNYK-JS-UGLIFYJS-1727251
SNYK-JS-COOKIE-8163060
SNYK-JS-MINIMATCH-3050818
SNYK-JS-NODEFORGE-2330875
SNYK-JS-NODEFORGE-2331908
SNYK-JS-NODEFORGE-2430337
SNYK-JS-NODEFORGE-2430341
SNYK-JS-ONHEADERS-10773729
SNYK-JS-PATHTOREGEXP-7925106
SNYK-JS-PATHTOREGEXP-8482416
SNYK-JS-SEND-7926862
npm:braces:20180219
SNYK-JS-SERVESTATIC-7926865
SNYK-JS-ELLIPTIC-7577916
SNYK-JS-ELLIPTIC-7577917
SNYK-JS-PBKDF2-10495496
SNYK-JS-PBKDF2-10495498
SNYK-JS-POSTCSS-1255640
Release notes
Package name: @testing-library/jest-dom
5.17.0 (2023-07-18)
Features
toHaveAccessibleErrorMessage
better implementing the spec, deprecatetoHaveErrorMessage
(#503) (d717c66)5.16.5 (2022-08-04)
Bug Fixes
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: