Skip to content

[Snyk] Upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0 #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 1 version ahead of your current version.

  • The recommended version was released 2 years ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-ANSIHTML-1296849
696 Proof of Concept
high severity Code Injection
SNYK-JS-LODASHTEMPLATE-1088054
696 Proof of Concept
high severity Prototype Pollution
SNYK-JS-MERGE-1040469
696 No Known Exploit
high severity Prototype Pollution
SNYK-JS-MERGE-1042987
696 Proof of Concept
high severity Inefficient Regular Expression Complexity
SNYK-JS-MICROMATCH-6838728
696 No Known Exploit
high severity Inefficient Regular Expression Complexity
SNYK-JS-MICROMATCH-6838728
696 No Known Exploit
high severity Prototype Pollution
SNYK-JS-UNSETVALUE-2400660
696 No Known Exploit
high severity Path Traversal
SNYK-JS-WEBPACKDEVMIDDLEWARE-6476555
696 Proof of Concept
high severity Denial of Service (DoS)
SNYK-JS-WS-7266574
696 Proof of Concept
high severity Denial of Service (DoS)
SNYK-JS-WS-7266574
696 Proof of Concept
high severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-8172694
696 No Known Exploit
high severity Improper Handling of Extra Parameters
SNYK-JS-FOLLOWREDIRECTS-6141137
696 Proof of Concept
high severity Denial of Service (DoS)
SNYK-JS-HTTPPROXYMIDDLEWARE-8229906
696 Proof of Concept
high severity Server-side Request Forgery (SSRF)
SNYK-JS-IP-6240864
696 Proof of Concept
high severity Prototype Pollution
SNYK-JS-LOADERUTILS-3043105
696 No Known Exploit
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-LOADERUTILS-3105943
696 No Known Exploit
medium severity Cross-site Scripting (XSS)
SNYK-JS-WEBPACK-7840298
696 Proof of Concept
medium severity Prototype Pollution
SNYK-JS-YARGSPARSER-560381
696 Proof of Concept
medium severity Prototype Pollution
SNYK-JS-YARGSPARSER-560381
696 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PROMPTS-1729737
696 Proof of Concept
medium severity Command Injection
SNYK-JS-REACTDEVUTILS-1083268
696 Proof of Concept
medium severity Server-side Request Forgery (SSRF)
SNYK-JS-REQUEST-3361831
696 Proof of Concept
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-6444610
696 Proof of Concept
low severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-WORDWRAP-3149973
696 Proof of Concept
critical severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-7577918
696 Proof of Concept
critical severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-8187303
696 Proof of Concept
critical severity Information Exposure
SNYK-JS-ELLIPTIC-8720086
696 Proof of Concept
medium severity Open Redirect
SNYK-JS-EXPRESS-6474509
696 No Known Exploit
medium severity Cross-site Scripting
SNYK-JS-EXPRESS-7926867
696 No Known Exploit
critical severity Predictable Value Range from Previous Values
SNYK-JS-FORMDATA-10841150
696 Proof of Concept
critical severity Predictable Value Range from Previous Values
SNYK-JS-FORMDATA-10841150
696 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-GLOBPARENT-1016905
696 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-HTMLMINIFIER-3091181
696 Proof of Concept
medium severity Server-Side Request Forgery (SSRF)
SNYK-JS-IP-7148531
696 Proof of Concept
medium severity Reverse Tabnabbing
SNYK-JS-ISTANBULREPORTS-2328088
696 No Known Exploit
medium severity Prototype Pollution
SNYK-JS-JSON5-3182856
696 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-LOADERUTILS-3042992
696 No Known Exploit
critical severity Incomplete List of Disallowed Inputs
SNYK-JS-BABELTRAVERSE-5962462
696 Proof of Concept
critical severity Incomplete List of Disallowed Inputs
SNYK-JS-BABELTRAVERSE-5962463
696 Proof of Concept
high severity Asymmetric Resource Consumption (Amplification)
SNYK-JS-BODYPARSER-7926860
696 No Known Exploit
high severity Excessive Platform Resource Consumption within a Loop
SNYK-JS-BRACES-6838727
696 Proof of Concept
high severity Excessive Platform Resource Consumption within a Loop
SNYK-JS-BRACES-6838727
696 Proof of Concept
high severity Inefficient Regular Expression Complexity
SNYK-JS-MICROMATCH-6838728
696 No Known Exploit
high severity Improper Verification of Cryptographic Signature
SNYK-JS-NODEFORGE-2430339
696 No Known Exploit
high severity Cross-site Scripting (XSS)
SNYK-JS-SERIALIZEJAVASCRIPT-536840
696 No Known Exploit
high severity Arbitrary Code Injection
SNYK-JS-SERIALIZEJAVASCRIPT-570062
696 Proof of Concept
high severity Cross-site Scripting (XSS)
SNYK-JS-SERIALIZEJAVASCRIPT-6056521
696 No Known Exploit
high severity Remote Code Execution (RCE)
SNYK-JS-SHELLQUOTE-1766506
696 No Known Exploit
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-SSRI-1246392
696 Proof of Concept
high severity Excessive Platform Resource Consumption within a Loop
SNYK-JS-BRACES-6838727
696 Proof of Concept
high severity Improper Verification of Cryptographic Signature
SNYK-JS-BROWSERIFYSIGN-6037026
696 No Known Exploit
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-CROSSSPAWN-8303230
696 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-MINIMATCH-3050818
696 No Known Exploit
medium severity Open Redirect
SNYK-JS-NODEFORGE-2330875
696 Proof of Concept
medium severity Prototype Pollution
SNYK-JS-NODEFORGE-2331908
696 No Known Exploit
medium severity Improper Verification of Cryptographic Signature
SNYK-JS-NODEFORGE-2430337
696 No Known Exploit
medium severity Improper Verification of Cryptographic Signature
SNYK-JS-NODEFORGE-2430341
696 No Known Exploit
medium severity Improper Handling of Unexpected Data Type
SNYK-JS-ONHEADERS-10773729
696 No Known Exploit
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-7925106
696 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-PATHTOREGEXP-8482416
696 Proof of Concept
medium severity Denial of Service (DoS)
SNYK-JS-SOCKJS-575261
696 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-TERSER-2806366
696 No Known Exploit
medium severity Prototype Pollution
SNYK-JS-TOUGHCOOKIE-5672873
696 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-UGLIFYJS-1727251
696 No Known Exploit
medium severity Cross-site Scripting (XSS)
SNYK-JS-COOKIE-8163060
696 No Known Exploit
low severity Regular Expression Denial of Service (ReDoS)
npm:braces:20180219
696 Proof of Concept
critical severity Generation of Predictable Numbers or Identifiers
SNYK-JS-PBKDF2-10495496
696 Proof of Concept
critical severity Generation of Predictable Numbers or Identifiers
SNYK-JS-PBKDF2-10495498
696 No Known Exploit
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-POSTCSS-1255640
696 Proof of Concept
medium severity Prototype Pollution
SNYK-JS-TOUGHCOOKIE-5672873
696 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-BROWSERSLIST-1090194
696 Proof of Concept
low severity Cross-site Scripting
SNYK-JS-SEND-7926862
696 No Known Exploit
low severity Cross-site Scripting
SNYK-JS-SERVESTATIC-7926865
696 No Known Exploit
critical severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-7577916
696 Proof of Concept
critical severity Improper Verification of Cryptographic Signature
SNYK-JS-ELLIPTIC-7577917
696 Proof of Concept
Release notes
Package name: @testing-library/jest-dom from @testing-library/jest-dom GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade @testing-library/jest-dom from 5.16.5 to 5.17.0.

See this package in npm:
@testing-library/jest-dom

See this project in Snyk:
https://app.snyk.io/org/mohammadnewton/project/22edd24b-54ca-4e0b-a30b-3a42f37de584?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've opened this pull request to upgrade the @testing-library/jest-dom dependency to its latest version, 5.17.0. This essential update primarily aims to resolve a significant number of identified security vulnerabilities across various components, enhancing the overall security posture of the project. Additionally, it brings in an improved matcher for accessible error messages.

Highlights

  • Dependency Upgrade: Upgraded the @testing-library/jest-dom package from version 5.16.5 to 5.17.0.
  • Security Fixes: Addressed a multitude of security vulnerabilities, including critical, high, and medium severities, such as Regular Expression Denial of Service (ReDoS), Code Injection, and Prototype Pollution, by updating the dependency.
  • Feature Enhancement and Deprecation: Introduced the new toHaveAccessibleErrorMessage matcher, which better aligns with accessibility specifications, and deprecated the older toHaveErrorMessage.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, upgrades the @testing-library/jest-dom package. The change updates the version in package.json from ^5.16.4 to ^5.17.0. This is an important security update that resolves multiple vulnerabilities as detailed in the PR description. My review confirms the change is correct for its purpose. I have also included a recommendation to move testing-related dependencies to devDependencies to optimize the production build, which can be addressed in this PR or a follow-up.

@@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"@testing-library/jest-dom": "^5.16.4",
"@testing-library/jest-dom": "^5.17.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This dependency upgrade is important for security. However, @testing-library/jest-dom is a testing library and should be in devDependencies rather than dependencies to avoid unnecessarily including it in the production build. While this PR didn't introduce this, it's a good opportunity to correct it. I'd recommend moving this and other testing-related libraries like @testing-library/react and @testing-library/user-event to devDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants