Skip to content

improve IsColorTerminal windows support #23

improve IsColorTerminal windows support

improve IsColorTerminal windows support #23

Triggered via pull request November 12, 2023 13:44
Status Success
Total duration 29s
Artifacts

golangci-lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 10 warnings
lint: ascii.go#L80
line is 128 characters (lll)
lint: cmd/jc/main.go#L50
SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
lint: cmd/jc/main.go#L127
S1002: should omit comparison to bool constant, can be simplified to `*flagColorize` (gosimple)
lint: cmd/jc/main.go#L139
S1002: should omit comparison to bool constant, can be simplified to `*flagPretty` (gosimple)
lint: codec.go#L29
File is not `gofumpt`-ed with `-extra` (gofumpt)
lint: codec.go#L43
File is not `gofumpt`-ed with `-extra` (gofumpt)
lint: codec.go#L113
naked return in func `constructCodec` with 134 lines of code (nakedret)
lint: codec.go#L116
missing cases in switch of type reflect.Kind: reflect.Invalid, reflect.Complex64, reflect.Complex128, reflect.Chan, reflect.Func, reflect.UnsafePointer (exhaustive)
lint: codec.go#L209
naked return in func `constructCodec` with 134 lines of code (nakedret)
lint: codec.go#L366
missing cases in switch of type reflect.Kind: reflect.Invalid, reflect.Bool, reflect.Float32, reflect.Float64, reflect.Complex64, reflect.Complex128, reflect.Array, reflect.Chan, reflect.Func, reflect.Interface, reflect.Map, reflect.Pointer|reflect.Ptr, reflect.Slice, reflect.Struct, reflect.UnsafePointer (exhaustive)
lint: cmd/jc/main.go#L11
package-comments: package comment is detached; there should be no blank lines between it and the package statement (revive)
lint: cmd/jc/main.go#L144
if-return: redundant if ...; err != nil check, just return error instead. (revive)
lint: decode.go#L16
unused-parameter: parameter 'p' seems to be unused, consider removing or renaming it as _ (revive)
lint: decode.go#L281
redefines-builtin-id: redefinition of the built-in function new (revive)
lint: decode.go#L635
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
lint: decode.go#L714
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
lint: decode.go#L795
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive)
lint: encode.go#L19
unused-parameter: parameter 'p' seems to be unused, consider removing or renaming it as _ (revive)
lint: encode.go#L767
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
lint: encode.go#L782
unused-parameter: parameter 'p' seems to be unused, consider removing or renaming it as _ (revive)