removed the reused code and did the fix #2521
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
eliork
reviewed
May 28, 2023
Comment on lines
24
to
32
| if (list1 == NULL && list2 == NULL) { | ||
| return NULL; | ||
| } | ||
| if (list1 == NULL) { | ||
| return list2; | ||
| } | ||
| if (list2 == NULL) { | ||
| return list1; | ||
| } |
Contributor
There was a problem hiding this comment.
I would keep these lines, as they are taking care of extreme cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Please make sure the file name is lowercase and a duplicate file does not already exist before merging.