Skip to content

Create 94-Binary-Tree-Inorder-Traversal.kt #1614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 29, 2022
Merged

Conversation

a93a
Copy link
Collaborator

@a93a a93a commented Dec 28, 2022

@neetcode-gh
Copy link
Owner

Looks good but can you start following the new file naming convention:

0094-binary-tree-inorder-traversal

Basically just add leading zeroes to keep file names sorted and the filename should be lowercase and exactly match the leetcode problem url extension. leetcode.com/problems/binary-tree-inorder-traversal/

@a93a
Copy link
Collaborator Author

a93a commented Dec 28, 2022

@neetcode-gh Thanks for your comment. I started using this convention for my latests PRs. I have a few ongoing PR with the old format, should I close them and reopen new PRs. Or alternativly, could you accept these (Kotlin PRs) and i'll make a new commit and change all of these names to the new convention afterwards?

Thanks.

@Ahmad-A0 Ahmad-A0 merged commit 1a10732 into neetcode-gh:main Dec 29, 2022
@a93a a93a deleted the 94 branch January 2, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants