Update 283-Move-Zeroes.js #1596
Conversation
Added solution with linear space just for reference's sake.
javascript/283-Move-Zeroes.js
Outdated
|
|
||
| for (let i = 0; i < nums.length; i++) { | ||
| if (nums[i] === 0) { | ||
| right--; |
There was a problem hiding this comment.
Add continue an remove else branch
There was a problem hiding this comment.
@aakhtar3, I updated the code, we don't need else or the continue part now.
Updated the logic. We don't need the "else" part nor do we require "continue".
javascript/283-Move-Zeroes.js
Outdated
| const zeroAtTheEnd = Array(nums.length).fill(0); | ||
| let left = 0; | ||
| for (let i = 0; i < nums.length; i++) { | ||
| if (nums[i]) { |
There was a problem hiding this comment.
You should define your if conditions
There was a problem hiding this comment.
@aakhtar3, What do you mean by defining if conditions?
There was a problem hiding this comment.
Look at the Space O(1) if condition
javascript/283-Move-Zeroes.js
Outdated
|
|
||
| const zeroAtTheEnd = Array(nums.length).fill(0); | ||
| let left = 0; | ||
| for (let i = 0; i < nums.length; i++) { |
There was a problem hiding this comment.
Most of the solutions for 2 pointer, sliding window, and cyclic sort are in while loop. Easier to remember that pattern over for loop
There was a problem hiding this comment.
Hey @aakhtar3, check now. Is this ok?
There was a problem hiding this comment.
Let's do this
const arr = new Array(nums.length).fill(0);
let [ left, right ] = [ 0, 0 ];
while (right < nums.length) {
const isZero = (nums[right] === 0);
if (!isZero) {
arr[left] = nums[right];
left++;
}
right++;
}
return arr;There was a problem hiding this comment.
That could work, let me try to submit it on leetCode.
There was a problem hiding this comment.
Oh, shoot! we won't be able to because we're creating a new array.
There was a problem hiding this comment.
But I did try some test cases and it seems to run just fine. I'll update the code.
There was a problem hiding this comment.
Please check now @aakhtar3
Added a descriptive if condition.
Updated the code as suggested.
javascript/283-Move-Zeroes.js
Outdated
| @@ -1,3 +1,29 @@ | |||
| /** | |||
| * Linear Time | |||
javascript/283-Move-Zeroes.js
Outdated
| @@ -1,3 +1,29 @@ | |||
| /** | |||
| * Linear Time | |||
| * Time Complexity O(N) | Space Complexity O(N); | |||
updating solution description.
|
@aakhtar3, I update the file with the suggested changes. Please have a look. |
Added solution with linear space just for reference's sake.
File(s) Modified: 283-Move-Zeroes.js
Language(s) Used: JavaScript