Update BaseSpec and FutureSpec traits

JAVA-4181
neerajbhatt · Apr 12, 2022 · 4b158d0 · 4b158d0
1 parent 7a0b575
commit 4b158d0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 36 deletions.
diff --git a/driver-scala/src/it/scala/org/mongodb/scala/BaseSpec.scala b/driver-scala/src/it/scala/org/mongodb/scala/BaseSpec.scala
@@ -16,8 +16,9 @@
 package org.mongodb.scala
 
 import org.junit.runner.RunWith
-import org.scalatest.{ FlatSpec, Matchers }
+import org.scalatest.flatspec.AnyFlatSpec
+import org.scalatest.matchers.should.Matchers
 import org.scalatestplus.junit.JUnitRunner
 
 @RunWith(classOf[JUnitRunner])
-abstract class BaseSpec extends FlatSpec with Matchers {}
+abstract class BaseSpec extends AnyFlatSpec with Matchers {}
diff --git a/driver-scala/src/it/scala/org/mongodb/scala/FuturesSpec.scala b/driver-scala/src/it/scala/org/mongodb/scala/FuturesSpec.scala
@@ -21,47 +21,21 @@ import org.scalatest.time.{ Millis, Seconds, Span }
 
 import scala.concurrent.Future
 import scala.language.implicitConversions
-import scala.util.{ Failure, Success }
 
 trait FuturesSpec extends ScalaFutures {
 
   implicit val defaultPatience: PatienceConfig = PatienceConfig(timeout = Span(60, Seconds), interval = Span(5, Millis))
 
-  implicit def observableToFuture[TResult](observable: Observable[TResult]): Future[Seq[TResult]] =
-    observable.toFuture()
-
-  implicit def observableToFutureConcept[T](observable: Observable[T]): FutureConcept[Seq[T]] = {
-    val future: Future[Seq[T]] = observable
-    new FutureConcept[Seq[T]] {
-      def eitherValue: Option[Either[Throwable, Seq[T]]] = {
-        future.value.map {
-          case Success(o) => Right(o)
-          case Failure(e) => Left(e)
-        }
-      }
-      def isExpired: Boolean = false
+  implicit def observableToFuture[T](observable: Observable[T]): Future[Seq[T]] =
+    observable.collect().toFuture()
 
-      // Scala Futures themselves don't support the notion of a timeout
-      def isCanceled: Boolean = false // Scala Futures don't seem to be cancelable either
-    }
-  }
-
-  implicit def observableToFuture[TResult](observable: SingleObservable[TResult]): Future[TResult] =
+  implicit def singleObservableToFuture[T](observable: SingleObservable[T]): Future[T] =
     observable.toFuture()
-  implicit def observableToFutureConcept[T](observable: SingleObservable[T]): FutureConcept[T] = {
-    val future: Future[T] = observable.toFuture()
-    new FutureConcept[T] {
-      def eitherValue: Option[Either[Throwable, T]] = {
-        future.value.map {
-          case Success(o) => Right(o)
-          case Failure(e) => Left(e)
-        }
-      }
-      def isExpired: Boolean = false
 
-      // Scala Futures themselves don't support the notion of a timeout
-      def isCanceled: Boolean = false // Scala Futures don't seem to be cancelable either
-    }
-  }
+  implicit def observableToFutureConcept[T](observable: Observable[T]): FutureConcept[Seq[T]] =
+    convertScalaFuture(observable.collect().toFuture())
+
+  implicit def singleObservableToFutureConcept[T](observable: SingleObservable[T]): FutureConcept[T] =
+    convertScalaFuture(observable.toFuture())
 
 }