feat: added support for switching variants #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
beersandrew
commented
Jul 19, 2024
beersandrew
commented
- built a new wasm version with variant related functions
- optionally show a new line of information in the header if the asset has variants to show the default prim, top / first variant set, and the top / first variant set options
- await loading and drawing and setting a variant as it can trigger a fetch which can freeze the page
- wasm file grew because of removing asyncify_remove, not worth it to continuously break the page on new functionality, will revisit later
beersandrew
force-pushed
the
feature/switch-variants
branch
from
4fa54b6 to
3f4259b
Compare
- built a new wasm version with variant related functions - optionally show a new line of information in the header if the asset has variants to show the default prim, top / first variant set, and the top / first variant set options - await loading and drawing and setting a variant as it can trigger a fetch which can freeze the page - wasm file grew because of removing asyncify_remove, not worth it to continuously break the page on new functionality, will revisit later
- don't allow for multiple change listeners
beersandrew
force-pushed
the
feature/switch-variants
branch
from
3f4259b to
c2308f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.