Allow usage of system provided status-code #258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The current cmake buildsystem vendors the
status-code
headers which is at odds with most package managers which require using the version provided through them. Furthermore it is unergonomic for users who need to include additional categories likecom_code.hpp
.Solution Sketch
Add a cmake feature toggle which instructs cmake to look for an installed
status-code
package. If configured that way, we would not install anystatus-code
headers but reference the importedstatus-code::hl
target.Additional explanatory comments
3.5
as that is already required byquickcpplib
. I think it should be considered to require an even newer version as a similar discussion on llvm-dev last year revealed that all current LTS platforms support at least3.6.1
(or3.13.4
if one is willing to sacrifice RHEL 6 and Debian 9 support).