Fix Boost.System trait namespacing #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the [`outcome_throw_as_system_error_with_payload(BoostErrorCodeEnum &&)`](https://ned14.github.io/outcome/reference/functions/policy/outcome_throw_as_system_error_with_payload_boost_enum/) page refers to the trait class `boost::system::errc::is_error_meow_enum<BoostErrorCodeEnum>`. As per the [Boost.System docs](https://www.boost.org/doc/libs/1_70_0/libs/system/doc/html/system.html#ref_boostsystemerror_code_hpp) the trait is spelled `boost::system::is_error_meow_enum` (no `errc` namespace). Happily this error does not appear to be reproduced anywhere in the actual code: - [`error_code_registration.cpp`](doc/src/snippets/boost-only/error_code_registration.cpp) puts the specialization in `boost::system` - [`boost_result.hpp`](https://github.com/ned14/outcome/blob/develop/include/outcome/boost_result.hpp#L69) just opens the namespace `boost::system::errc` so that (if I follow) ADL allows calling outcome_throw_as_system_error_with_payload(boost::system::errc::errc_t)`.
|
Many thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
outcome_throw_as_system_error_with_payload(BoostErrorCodeEnum &&)page refers to the trait classboost::system::errc::is_error_meow_enum<BoostErrorCodeEnum>. As per the Boost.System docs the trait is spelledboost::system::is_error_meow_enum(noerrcnamespace).Happily this error does not appear to be reproduced anywhere in the actual code:
error_code_registration.cppputs the specialization inboost::systemboost_result.hppjust opens the namespaceboost::system::errcso that (if I follow) ADL allows callingoutcome_throw_as_system_error_with_payload(boost::system::errc::errc_t).