feat(accessibility): add inert to forwardedProps #2773
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 15e7505:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing we found working on the accessibility of our components is that simply putting aria-hidden on a parent element on web is problematic. If you have certain elements inside of this component like text inputs, the browser will log errors if you put aria-hidden on a parent element without it also being on all the individual children.
You have to put the inert attribute on the parent to actually hide the entire tree of children from the screen reader properly.
Inert reference:
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inert
This will help trap and disable underneath components with other libraries like navigation:
react-navigation/react-navigation#12541