Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sorting for last used column #56

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Fix sorting for last used column #56

merged 1 commit into from
Jun 15, 2024

Conversation

krassowski
Copy link
Member

Reference Issues or PRs

Fixes #49 - ensures that first click on the column sorts from most recent to not used at all:

image

What does this implement/fix?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

On first click sort by most recent first;
make sure that never is after the oldest
@krassowski krassowski added the bug label Jun 15, 2024
Copy link
Contributor

Binder 👈 Launch a Binder on branch nebari-dev/jupyterlab-new-launcher/fix-sorting

@krassowski krassowski merged commit a703085 into main Jun 15, 2024
8 checks passed
@krassowski krassowski deleted the fix-sorting branch June 15, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong sort order for date: "Never" should be the last or first item
1 participant