Fix: glue with nested multi values#96
Merged
Merged
Conversation
865eac1 to
35c5b6c
Compare
simoneb
reviewed
Mar 3, 2022
ramonmulia
reviewed
Mar 3, 2022
simoneb
reviewed
Mar 4, 2022
Eomm
reviewed
Mar 4, 2022
simoneb
approved these changes
Mar 4, 2022
This was referenced Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94
In this issue, we catch a bug when one of the arguments, except the last one in SQL.glue(args) has nested values.
Example:
the cause is in this piece of code
In the second if "strings.length > pieces[i].values.length" we check if strings.length if higher than pieces[I].values.length, and only if this condition is true we change the value of carryover variable, but we only add the separator if the variable carryover type is a string.
So every time that one of the pieces (except the last one because we don't need the separator in this case) doesn't match with the second "if" we will not have the addition of the separator.