Skip to content

Fix test runner events parsing and align with node 20.7.0#83

Merged
msebastianb merged 3 commits intomasterfrom
82-fix_parsing
Sep 27, 2023
Merged

Fix test runner events parsing and align with node 20.7.0#83
msebastianb merged 3 commits intomasterfrom
82-fix_parsing

Conversation

@msebastianb
Copy link
Contributor

@msebastianb msebastianb commented Sep 26, 2023

This is a list of things changed on node test runner since the latest release:

  • File string format is changed now it returns the url scheme too then in our case has file: in front of the path
  • generatedMessage must be true in that case because the message is automatically generated, if a custom message is passed as the third parameter of for example strictEquale function the variable will be false
  • On subtestFailed failure type now the cause is "<number> subtest failed" instead of an empty object
  • On testTimeoutFailure failure type now the cause is "test timed out after <timeout ms>" instead of an empty object

Suggested solution:

  • Parse the file url and return it as expected
  • Align the expected tests results with node 20.7.0

Closes #82

@msebastianb msebastianb added the bug Something isn't working label Sep 26, 2023
@msebastianb msebastianb self-assigned this Sep 26, 2023
@msebastianb msebastianb marked this pull request as draft September 26, 2023 15:50
@msebastianb msebastianb marked this pull request as ready for review September 26, 2023 16:37
@msebastianb msebastianb requested a review from simoneb September 26, 2023 16:38
@msebastianb msebastianb merged commit 41efff7 into master Sep 27, 2023
@msebastianb msebastianb deleted the 82-fix_parsing branch September 27, 2023 07:56
@github-actions github-actions bot mentioned this pull request Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing results do not reflect test results

2 participants