Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade eslint v8 to v7.32 because of compatibility issues #178

Closed
wants to merge 1 commit into from

Conversation

radomird
Copy link
Contributor

@radomird radomird commented Dec 7, 2021

The eslint-config-standard is not yet compatible with eslint version 8, see standard/eslint-config-standard#192. Since this is blocking the release I've decided to downgrade eslint to version 7.32.0 until the issue gets resolved.

@radomird radomird self-assigned this Dec 7, 2021
@simoneb
Copy link
Member

simoneb commented Dec 7, 2021

Why is the build green if eslint does not work?

@radomird
Copy link
Contributor Author

radomird commented Dec 7, 2021

Good question. Build is indeed green but when trying to run the release workflow then it complains about it. I tried to reproduce it in a private test repo. and at first I wasn't successful but then when I fiddled with the eslint version (updated from 8.2.0 -> 8.4.0 - latest) then it failed on npm install. I'll play around with it a bit more to try to get a clear answer.

@simoneb
Copy link
Member

simoneb commented Dec 7, 2021

See #179. It is now failing as I would expect, and the problem was in the build process which was caching dependencies. Can you close this PR and make this change in that branch? Once that PR is green, we're good to merge.

@radomird radomird closed this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants