-
Notifications
You must be signed in to change notification settings - Fork 13
Change regex to accept both issue formats #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please describe what format this supports? Also, please include unit tests
Sry for the prettier changes. Will revert |
247cf6e
to
0a64925
Compare
check out the unit tests in the codebase, they can serve as a blueprint about what we are testing and want to test |
@alt-13 just a reminder to update/add tests please |
I am sorry. I was unavailable last week. Please clarify if the output of the action should be seen as an external issue (owner/repo#123) as this format also can link to an external issue. |
Thanks for the follow up. Based on the documentation, the current output seems to be in the form "some/repo#123". In hindsight maybe that should have been a url, but since this format supports both internal and external issues, I'd say we can easily keep this format to link any issue, whether internal or extenal. What do you think? |
Yes, I think so too. As the documentation also states two different owner/repo combinations it is clear that it not only is linking internal but also external issues. So for me, it is ok as it is. I hope there is no codestyle issue anywhere. |
please fix the linting error. you can run linting locally before pushing. can you also please undo the formatting changes to the documentation? |
All requested changes applied. Is there anything else to fix? |
Closes #514
Maybe not the most elegant way but my regex knowledge is limited.
Change regex to accept both issue formats:
closes https://github.com/org-name/repo/issues/123
closes org-name/repo#123