fix: correct read mode for storage_has_key #8968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pugachAG: can you help review this please? |
pugachAG
approved these changes
Apr 25, 2023
|
LGTM, got only one suggestion: |
nikurt
pushed a commit
that referenced
this pull request
Apr 25, 2023
In `storage_has_key` we were setting `KeyLookupMode::FlatStorage` by default. This is correct for most reads, but not for reads inside contracts, as it impacts chunk cache and contract call costs. We must read from flat storage deterministically and derive lookup mode from protocol version.
nikurt
pushed a commit
that referenced
this pull request
Apr 28, 2023
In `storage_has_key` we were setting `KeyLookupMode::FlatStorage` by default. This is correct for most reads, but not for reads inside contracts, as it impacts chunk cache and contract call costs. We must read from flat storage deterministically and derive lookup mode from protocol version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
storage_has_keywe were settingKeyLookupMode::FlatStorageby default. This is correct for most reads, but not for reads inside contracts, as it impacts chunk cache and contract call costs.We must read from flat storage deterministically and derive lookup mode from protocol version.