move the check for is_height_processed forward #7855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robin-near
approved these changes
Oct 17, 2022
mm-near
suggested changes
Oct 19, 2022
| @@ -2121,6 +2121,7 @@ fn test_sync_hash_validity() { | |||
| } | |||
|
|
|||
| /// Only process one block per height | |||
| #[ignore] | |||
There was a problem hiding this comment.
Can we fix this test? (or create another test that would verify that we will not forward a block in such scenario)
There was a problem hiding this comment.
I'm going to fix this test in another PR, where I will move all the process block related code in client actor to client, but that's a bigger change and I want to separate it
| @@ -1412,6 +1412,20 @@ impl ClientActor { | |||
| debug!(target: "client", tail_height = tail, "Dropping a block that is too far behind."); | |||
| return; | |||
| } | |||
| // drop the block if a) it is not requested, b) we already processed this height, c) it is not building on top of current head | |||
There was a problem hiding this comment.
please also mention, that we have to do this check ASAP - as the non-requested block means that we can get spammed.
mm-near
approved these changes
Oct 20, 2022
nikurt
pushed a commit
that referenced
this pull request
Oct 25, 2022
Move the check for is_height_processed before process_block_header. Previously, this check happens after, which means, the node will re-process the block header (which takes a few ms) and re-broadcast an invalid block before drops it. In the case when there are many invalid blocks circulating in the network, this can cause the node to be too busy,
nikurt
pushed a commit
that referenced
this pull request
Nov 7, 2022
Move the check for is_height_processed before process_block_header. Previously, this check happens after, which means, the node will re-process the block header (which takes a few ms) and re-broadcast an invalid block before drops it. In the case when there are many invalid blocks circulating in the network, this can cause the node to be too busy,
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Move the check for is_height_processed before process_block_header. Previously, this check happens after, which means, the node will re-process the block header (which takes a few ms) and re-broadcast an invalid block before drops it. In the case when there are many invalid blocks circulating in the network, this can cause the node to be too busy,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the check for is_height_processed before process_block_header. Previously, this check happens after, which means, the node will re-process the block header (which takes a few ms) and re-broadcast an invalid block before drops it. In the case when there are many invalid blocks circulating in the network, this can cause the node to be too busy,