refactor: simplify get_epoch_sync_data_hash #7726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-near
reviewed
Sep 29, 2022
| @@ -418,7 +409,23 @@ pub trait RuntimeAdapter: EpochManagerAdapter + Send + Sync { | |||
| prev_epoch_last_block_hash: &CryptoHash, | |||
| epoch_id: &EpochId, | |||
| next_epoch_id: &EpochId, | |||
| ) -> Result<CryptoHash, Error>; | |||
| ) -> Result<CryptoHash, Error> { | |||
There was a problem hiding this comment.
BTW - not sure why you called the PR "simplification"
There was a problem hiding this comment.
This is a red diff which removes the code. Implementing get_epoch_sync_data_hash once instead of overriding it twice is simpler. The logic is self is kept intact indeed.
mm-near
approved these changes
Sep 29, 2022
Can be implemented in the trait itself, its just a convenience fn at this point.
nikurt
pushed a commit
that referenced
this pull request
Oct 17, 2022
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #6910, depends on #7716