Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump crates version to 0.15.0 #7680

Merged
merged 2 commits into from
Sep 23, 2022
Merged

chore: bump crates version to 0.15.0 #7680

merged 2 commits into from
Sep 23, 2022

Conversation

frol
Copy link
Collaborator

@frol frol commented Sep 23, 2022

It has been a while since the last time we cut the crates releases. Let's do that with 1.29.0 release of nearcore.

Tagged: https://github.com/near/nearcore/releases/tag/crates-0.14.0

Notable changes:

Check here for a full changelog: crates-0.14.0...crates-0.15.0

@frol frol requested a review from miraclx September 23, 2022 11:47
@frol frol requested a review from a team as a code owner September 23, 2022 11:47
@frol frol requested a review from akhi3030 September 23, 2022 11:47
@akhi3030
Copy link
Collaborator

@mina86 : I figure this is something you should be able to review.

@matklad
Copy link
Contributor

matklad commented Sep 23, 2022

At some point we should write a github action or something to just auto-trigger publishing when a tag is pushed.

Comment on lines 59 to +60
[workspace.metadata.workspaces]
version = "0.14.0"
version = "0.15.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Although, I wonder if the new workspace inheritance feature that rustc 1.64.0's cargo ships with could help us here.

https://doc.rust-lang.org/nightly/cargo/reference/workspaces.html#the-package-table

But at least for now, this looks good!

@miraclx
Copy link
Contributor

miraclx commented Sep 23, 2022

@matklad said At some point we should write a github action or something to just auto-trigger publishing when a tag is pushed.

I figured with a PR, it's more visible and we can get approvals before the release is published, which do you think is better?

@frol frol merged commit 981456b into master Sep 23, 2022
@frol frol deleted the release/crates-0.15.0 branch September 23, 2022 14:14
nikurt pushed a commit that referenced this pull request Sep 26, 2022
It has been a while since the last time we cut the crates releases. Let's do that with 1.29.0 release of nearcore.

Tagged: https://github.com/near/nearcore/releases/tag/crates-0.15.0

Notable changes:

  - #6924
  - #6941
  - (BREAKING CHANGE) #7308

Check here for a full changelog: crates-0.14.0...crates-0.15.0
near-bulldozer bot pushed a commit that referenced this pull request Sep 27, 2022
…7707)

#7680 bumped the version of non-private crates to `0.15.0`. Unfortunately, the publish process failed, because `near-o11y` which is marked as a private package, is depended on by `near-vm-logic`, which is a non-private crate.

This adds a check to `themis`, to ensure we never get this kind of discrepancy merged into master.

Example Report:

<img width="498" alt="CleanShot 2022-09-27 at 19 53 10@2x" src="https://user-images.githubusercontent.com/16881812/192575063-93c35ffb-e01e-41d9-8d4a-2d904ae85409.png">
nikurt pushed a commit that referenced this pull request Nov 9, 2022
It has been a while since the last time we cut the crates releases. Let's do that with 1.29.0 release of nearcore.

Tagged: https://github.com/near/nearcore/releases/tag/crates-0.15.0

Notable changes:

  - #6924
  - #6941
  - (BREAKING CHANGE) #7308

Check here for a full changelog: crates-0.14.0...crates-0.15.0
nikurt pushed a commit that referenced this pull request Nov 9, 2022
…7707)

#7680 bumped the version of non-private crates to `0.15.0`. Unfortunately, the publish process failed, because `near-o11y` which is marked as a private package, is depended on by `near-vm-logic`, which is a non-private crate.

This adds a check to `themis`, to ensure we never get this kind of discrepancy merged into master.

Example Report:

<img width="498" alt="CleanShot 2022-09-27 at 19 53 10@2x" src="https://user-images.githubusercontent.com/16881812/192575063-93c35ffb-e01e-41d9-8d4a-2d904ae85409.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants