Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable life support for nearlib test #7667

Merged
merged 1 commit into from
Sep 22, 2022

Commits on Sep 22, 2022

  1. fix: disable life support for nearlib test

    What this test is intended to do is to spawn a local neard node and to
    run near-api-js tests against that.
    
    The purpose is to detect unintentional changes to near public API.
    
    We have disabled actually running the test a while ago, and today the
    build broke b/c api-js moved from yarn to pnpm.
    
    I think at this it's safe to kill this infra completely, as we weren't
    running it for a while.
    
    It would of course be nice to have some in-repo tests covering public
    JSON API, but I think we are currently server well-enough by betanet and
    testnet anyway.
    
    Testing public APIs via running tests of downstream projects upstream is
    clearly a wrong way to do that!
    matklad committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    e04cf94 View commit details
    Browse the repository at this point in the history