refactor: expose get_epoch_id as a method of EpochManagerAdapter #7666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mm-near
reviewed
Sep 22, 2022
chain/epoch-manager/src/adapter.rs
Outdated
| @@ -50,7 +50,10 @@ pub trait EpochManagerAdapter: Send + Sync { | |||
| fn get_next_epoch_id_from_prev_block(&self, parent_hash: &CryptoHash) | |||
| -> Result<EpochId, Error>; | |||
|
|
|||
| /// Get epoch start for given block hash. | |||
| /// Get [`EpochId`] from a block belonging to the epoch. | |||
| fn get_epoch_id(&self, hash: &CryptoHash) -> Result<EpochId, Error>; | |||
There was a problem hiding this comment.
should we call the argument 'block_hash' rather than hash ?
There was a problem hiding this comment.
Good catch! I specifically wanted to make this consistent, but fixed only one of the three places!
mm-near
approved these changes
Sep 22, 2022
Previously, this was only available on NightshadeRuntime, but seems fine to expose everywhere.
nikurt
pushed a commit
that referenced
this pull request
Sep 26, 2022
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6910, depends on #7665
Previously, this was only available on NightshadeRuntime, but seems fine
to expose everywhere.