chain: slight refactor in finality and ‘on chain’ check methods #7410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, change is_on_current_chain method to return boolean status rather than error if block is not on current chain. The method is used in two places: in one it’s only used as a boolean predicate so returned error is irrelevant; in the other one the caller performs another check and duplicates code for creating the error. Changing is_on_current_chain return bool simplifies both call sites. Secondly, rewrite check_block_final_and_canonical to accept a list of headers rather than operating on single block hash. (With that also change ‘block’ in name into ‘blocks’). This has a few motivations: i) it makes last final block header being fetched only once, ii) since caller needs access to the block header this makes it so that header is fetched only once and iii) moving fetching of the headers to the caller will actually help slightly in upcoming efforts for cold storage.
|
@mzhangmzz, friendly ping. |
mzhangmzz
approved these changes
Sep 6, 2022
mzhangmzz
approved these changes
Sep 6, 2022
nikurt
pushed a commit
that referenced
this pull request
Sep 7, 2022
Firstly, change is_on_current_chain method to return boolean status rather than error if block is not on current chain. The method is used in two places: in one it’s only used as a boolean predicate so returned error is irrelevant; in the other one the caller performs another check and duplicates code for creating the error. Changing is_on_current_chain return bool simplifies both call sites. Secondly, rewrite check_block_final_and_canonical to accept a list of headers rather than operating on single block hash. (With that also change ‘block’ in name into ‘blocks’). This has a few motivations: i) it makes last final block header being fetched only once, ii) since caller needs access to the block header this makes it so that header is fetched only once and iii) moving fetching of the headers to the caller will actually help slightly in upcoming efforts for cold storage.
nikurt
pushed a commit
that referenced
this pull request
Nov 9, 2022
Firstly, change is_on_current_chain method to return boolean status rather than error if block is not on current chain. The method is used in two places: in one it’s only used as a boolean predicate so returned error is irrelevant; in the other one the caller performs another check and duplicates code for creating the error. Changing is_on_current_chain return bool simplifies both call sites. Secondly, rewrite check_block_final_and_canonical to accept a list of headers rather than operating on single block hash. (With that also change ‘block’ in name into ‘blocks’). This has a few motivations: i) it makes last final block header being fetched only once, ii) since caller needs access to the block header this makes it so that header is fetched only once and iii) moving fetching of the headers to the caller will actually help slightly in upcoming efforts for cold storage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, change is_on_current_chain method to return boolean status
rather than error if block is not on current chain. The method is
used in two places: in one it’s only used as a boolean predicate so
returned error is irrelevant; in the other one the caller performs
another check and duplicates code for creating the error. Changing
is_on_current_chain return bool simplifies both call sites.
Secondly, rewrite check_block_final_and_canonical to accept a list of
headers rather than operating on single block hash. (With that also
change ‘block’ in name into ‘blocks’). This has a few motivations:
i) it makes last final block header being fetched only once, ii) since
caller needs access to the block header this makes it so that header
is fetched only once and iii) moving fetching of the headers to the
caller will actually help slightly in upcoming efforts for cold
storage.