Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to rocksdb dependency to 0.16.0 #4442

Merged
merged 6 commits into from
Jul 9, 2021
Merged

Update to rocksdb dependency to 0.16.0 #4442

merged 6 commits into from
Jul 9, 2021

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Jun 30, 2021

Issue: #3266

@mina86
Copy link
Contributor Author

mina86 commented Jun 30, 2021

I’ve given cursory look at the commits between 0.15 and 0.16 and didn’t notice anything breaking. I’ve run cargo test and run the node for a while but don’t really know if that’s sufficient testing for a storage library upgrade.

@ailisp
Copy link
Member

ailisp commented Jul 1, 2021

@mina86 The failing is about cargo-deny. We disallow any crate in Cargo.lock have two different versions. When there's third party dependency cause this (in this case, rocksdb 0.16), add the exception to deny.toml and make sure cargo-deny check bans pass locally

@mina86 mina86 enabled auto-merge (squash) July 1, 2021 23:20
@bowenwang1996
Copy link
Collaborator

@olonho @frol @khorolets please review this PR

@mina86
Copy link
Contributor Author

mina86 commented Jul 5, 2021

Haha. The number of reviewers is too damn high. ;) @olonho, could you also approve?

deny.toml Show resolved Hide resolved
@mina86 mina86 merged commit 34914ad into near:master Jul 9, 2021
@mina86 mina86 deleted the rdb branch July 9, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants