Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): fix the failing builds on an error due to non-existing … #4338

Closed
wants to merge 1 commit into from

Conversation

chefsale
Copy link
Contributor

@chefsale chefsale commented May 28, 2021

…features. Created a build to verify the fix works: https://buildkite.com/nearprotocol/nearcore-perf-release/builds/235. It seems before the features which don't exist would get ignored, but now it fails due to changes in tooling.

@chefsale chefsale self-assigned this May 28, 2021
@chefsale chefsale added T-SRE Team: issues relevant to the SRE team automerge labels May 28, 2021
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix does not seem right. We need to fix the feature names, I believe. The features themselves are definitely required unless I miss something

@miraclx
Copy link
Contributor

miraclx commented May 29, 2021

Yeah, we could directly activate them with nearcore/<feature> or at least proxy them in their respective Cargo.toml files instead of removing them outright. However, near-vm-runner-standalone doesn't depend on nearcore so we'll have to activate the required features on whatever dependencies it has.

@chefsale
Copy link
Contributor Author

chefsale commented May 29, 2021

@frol I believe that only neard uses the perf stats feature flags. Maybe I'm wrong. Cc: @bowenwang1996

@miraclx
Copy link
Contributor

miraclx commented May 29, 2021

FWIK, you're right, but not entirely, it's used in nearcore, near-network and near-performance-metrics-macros. So, neard and anything else that depends on those can just activate them via nearcore. The only crate that won't be needing those features is near-vm-runner-standalone because it depends on neither of those. But state-viewer and store-validator would.

@chefsale
Copy link
Contributor Author

chefsale commented May 29, 2021

Yes, near-vm-standalone-runner doesn't use it at all (compile time), but the two other binaries even they use it, I don't think there is any benefit of enabling it, as it is used to debug neard perfomance issues which neither state-viewer or store-validator actually need to have enabled. I think @bowenwang1996 can probably stamp if my thinking is correct here.

@chefsale chefsale closed this Jun 1, 2021
@Ekleog-NEAR Ekleog-NEAR deleted the remove-perf-from-not-needed branch March 29, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-SRE Team: issues relevant to the SRE team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants