feat: enable "how long did this thing run?" logging #4033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
requested review from
ailisp,
bowenwang1996,
evgenykuzyakov,
frol,
maxzaver,
olonho and
SkidanovAlex
as code owners
matklad
force-pushed
the
log-spans
branch
2 times, most recently
from
26eef58 to
4d04b4d
Compare
ailisp
approved these changes
Mar 4, 2021
|
Example output: note the |
This was referenced Mar 4, 2021
Tracing spans are a pairs of start/stop events, and can be used to monitor how well the code is performing in production and, if it is slow, which specific part is slow. To get this magic power, we need two things: * actually use `span!` macros from tracing (we already do in contract runtime, this PR adds one more span right at the entry point, now that we have a single entry point) * ask tracing to please print this valuable info, as it is disabled by default.
|
Yeah, makes sense. Left only It'd be cool though to figure out which things we should print by default. I'll see if I can up with "print all spans that took longer than 50ms". That definitelly should be possible with tracing, the question is, can I figure out how? That is, I feel we should merge this PR. |
frol
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracing spans are a pairs of start/stop events, and can be used to
monitor how well the code is performing in production and, if it is
slow, which specific part is slow. To get this magic power, we need two
things:
actually use
span!macros from tracing (we already do in contractruntime, this PR adds one more span right at the entry point, now that
we have a single entry point)
ask tracing to please print this valuable info, as it is disabled by
default.